Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove Azure DevOps PAT used for VMR synchronization - #6384

#6384
Merged
premun merged 1 commit into
dotnet:maindotnet/arcade-services:mainfrom
premun:prvysoky/secret-removalpremun/arcade-services:prvysoky/secret-removalCopy head branch name to clipboard
Jun 10, 2026
Merged

Remove Azure DevOps PAT used for VMR synchronization#6384
premun merged 1 commit into
dotnet:maindotnet/arcade-services:mainfrom
premun:prvysoky/secret-removalpremun/arcade-services:prvysoky/secret-removalCopy head branch name to clipboard

Conversation

@premun

@premun premun commented Jun 10, 2026

Copy link
Copy Markdown
Member

Fixes #6062

Copilot AI review requested due to automatic review settings June 10, 2026 09:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the Azure DevOps PAT secret definition from the VMR synchronization vault configuration as part of transitioning VMR sync pipelines away from PAT-based authentication (issue #6062).

Changes:

  • Deletes the dn-bot-all-orgs-code-r azure-devops-access-token secret entry from .vault-config/vmr-synchronization.1.yaml.
Comments suppressed due to low confidence (1)

.vault-config/vmr-synchronization.1.yaml:21

  • This vault config no longer provisions the dn-bot-all-orgs-code-r secret, but the VMR sync pipeline steps still reference it and pass it to vmr-sync.(sh|ps1) as --azdev-pat / -azdevPat (see eng/common/templates/steps/vmr-sync.yml around the additionalSyncs steps). With this removed, that variable will be empty/unset and the sync is likely to fail when cloning private AzDO repos.

Either update the pipeline/template to use the new MI-based token variable (e.g., $(AzdoToken)) for the additionalSyncs path as well, or keep this secret mapping until those references are removed.

secrets:
  BotAccount-dotnet-bot:
    type: github-account
    parameters:
      Name: dotnet-bot

@premun
premun enabled auto-merge (squash) June 10, 2026 09:28
@premun
premun disabled auto-merge June 10, 2026 09:35
@premun
premun merged commit d557655 into dotnet:main Jun 10, 2026
4 of 11 checks passed
@premun
premun deleted the prvysoky/secret-removal branch June 10, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transition VMR sync pipeline to MI over AzDo pats

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.