Automate Minimum Darc version bump - #6347
#6347Merged
dkurepa merged 1 commit intoJun 3, 2026
dotnet:maindotnet/arcade-services:mainfrom
dkurepa:dkurepa/AutoMinDarcVersionBumpdkurepa/arcade-services:dkurepa/AutoMinDarcVersionBumpCopy head branch name to clipboard
Merged
Automate Minimum Darc version bump#6347dkurepa merged 1 commit intodotnet:maindotnet/arcade-services:mainfrom dkurepa:dkurepa/AutoMinDarcVersionBumpdkurepa/arcade-services:dkurepa/AutoMinDarcVersionBumpCopy head branch name to clipboard
dkurepa merged 1 commit into
dotnet:maindotnet/arcade-services:mainfrom
dkurepa:dkurepa/AutoMinDarcVersionBumpdkurepa/arcade-services:dkurepa/AutoMinDarcVersionBumpCopy head branch name to clipboard
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an opt-in “breaking darc change” signal to the rollout workflow so production deployments can automatically bump the minimum required Darc version when a rollout PR is marked accordingly.
Changes:
- Extend
eng/prepare-rollout.ps1with a-BreakingDarcChangeswitch to apply thebreaking-darc-changelabel to the rollout PR. - Update the production deploy stage to detect the
breaking-darc-changelabel for the deployed commit and runProductConstructionService.Cli.exe set-min-darc-versionto the current Darc version. - Surface the breaking-darc-change selection in the rollout script’s summary output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| eng/prepare-rollout.ps1 | Adds a switch to optionally label the rollout PR as a breaking Darc change and reports that in the summary. |
| eng/pipelines/templates/stages/deploy.yaml | Adds a production-only step that checks PR labels for the deployed commit and bumps the minimum Darc version when breaking-darc-change is present. |
Comment on lines
+10
to
+13
| ### -d, --date <string> Date for the rollout in YYYY-MM-DD format (default: today) | ||
| ### -b, --BreakingDarcChange Adds the 'breaking-darc-change' label to the rollout PR, which | ||
| ### triggers an automatic bump of the minimum required darc version | ||
| ### during the production deployment |
Comment on lines
+202
to
+205
| } catch { | ||
| Write-Warning "Failed to add 'breaking-darc-change' label: $_" | ||
| Write-Warning "You may need to manually add the 'breaking-darc-change' label to the PR" | ||
| } |
| - task: AzureCLI@2 | ||
| displayName: Bump minimum darc version if breaking-darc-change label is present | ||
| inputs: | ||
| azureSubscription: "Darc: Maestro Production" |
| } | ||
| env: | ||
| GH_TOKEN: $(dotnet-bot-arcade-services-content-rw) | ||
| continueOnError: true |
premun
approved these changes
Jun 3, 2026
Member
Author
|
we can't merge this before #6348 |
dkurepa
marked this pull request as draft
June 3, 2026 14:16
Member
|
@dkurepa why? we can just not use it? |
Member
Author
oh right, that's true :D |
dkurepa
marked this pull request as ready for review
June 3, 2026 14:31
This was referenced Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6345