Create subscription trigger outcome API - #6324
#6324Merged
adamzip merged 7 commits intoMay 22, 2026
dotnet:maindotnet/arcade-services:mainfrom
adamzip:create-subscription-outcome-apiadamzip/arcade-services:create-subscription-outcome-apiCopy head branch name to clipboard
Merged
Create subscription trigger outcome API#6324adamzip merged 7 commits intodotnet:maindotnet/arcade-services:mainfrom adamzip:create-subscription-outcome-apiadamzip/arcade-services:create-subscription-outcome-apiCopy head branch name to clipboard
adamzip merged 7 commits into
dotnet:maindotnet/arcade-services:mainfrom
adamzip:create-subscription-outcome-apiadamzip/arcade-services:create-subscription-outcome-apiCopy head branch name to clipboard
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new v2020-02-20 Product Construction Service (PCS) read API for subscription update outcomes, along with generated client models/operations to consume it.
Changes:
- Introduces
SubscriptionOutcomesControllerwith endpoints to list outcomes (with filters) and fetch a single outcome by operation id. - Adds API DTOs for
SubscriptionOutcomeandSubscriptionOutcomeType. - Adds generated PCS client operations and models for subscription outcomes.
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ProductConstructionService/ProductConstructionService.Api/Api/v2020_02_20/Models/SubscriptionOutcome.cs | Adds API DTO + enum for subscription outcomes returned by the new endpoints. |
| src/ProductConstructionService/ProductConstructionService.Api/Api/v2020_02_20/Controllers/SubscriptionOutcomesController.cs | Adds new read-only controller endpoints to list/get subscription outcomes. |
| src/ProductConstructionService/Microsoft.DotNet.ProductConstructionService.Client/Generated/SubscriptionOutcomes.cs | Adds generated client operations for listing/getting subscription outcomes. |
| src/ProductConstructionService/Microsoft.DotNet.ProductConstructionService.Client/Generated/Models/SubscriptionOutcomeType.cs | Adds generated client enum for subscription outcome types. |
| src/ProductConstructionService/Microsoft.DotNet.ProductConstructionService.Client/Generated/Models/SubscriptionOutcome.cs | Adds generated client DTO for subscription outcomes. |
premun
reviewed
May 22, 2026
premun
previously approved these changes
May 22, 2026
| @@ -0,0 +1,25 @@ | ||
| using System; |
Member
There was a problem hiding this comment.
Looks like the generated code is missing headers. That can start breaking the build eventually.
premun
previously approved these changes
May 22, 2026
premun
approved these changes
May 22, 2026
dkurepa
added a commit
that referenced
this pull request
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6188