[7.0.2 Cherry-pick] Fix macOS CI: trust microsoft/mssql-release tap for Homebrew 5.2+ - #4365
#4365Merged
paulmedynski merged 1 commit intoJun 16, 2026
release/7.0dotnet/SqlClient:release/7.0from
dev/automation/pr-4363-to-7.0.2dotnet/SqlClient:dev/automation/pr-4363-to-7.0.2Copy head branch name to clipboard
Merged
[7.0.2 Cherry-pick] Fix macOS CI: trust microsoft/mssql-release tap for Homebrew 5.2+#4365paulmedynski merged 1 commit intorelease/7.0dotnet/SqlClient:release/7.0from dev/automation/pr-4363-to-7.0.2dotnet/SqlClient:dev/automation/pr-4363-to-7.0.2Copy head branch name to clipboard
paulmedynski merged 1 commit into
release/7.0dotnet/SqlClient:release/7.0from
dev/automation/pr-4363-to-7.0.2dotnet/SqlClient:dev/automation/pr-4363-to-7.0.2Copy head branch name to clipboard
Conversation
) * Fix macOS CI: trust microsoft/mssql-release tap for Homebrew 5.2+ Homebrew 5.2.0 made untrusted-tap enforcement the default. After 'brew update' pulls in the new version, 'brew install mssql-tools18' is refused because the microsoft/mssql-release tap is untrusted. This caused sqlcmd to never be installed (exit code 127), so the SQL Server connectivity check looped for 72 attempts and failed. Add 'brew trust microsoft/mssql-release' after tapping and before 'brew update' to explicitly trust the Microsoft tap. * Address PR #4363 review feedback - Move 'brew trust' after 'brew update' so it works even when the runner image starts with a Homebrew version older than 5.2. - Add a fail-fast check after 'brew install mssql-tools18' to immediately abort with a clear error if sqlcmd is not on PATH, avoiding the 6-minute timeout loop.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## release/7.0 #4365 +/- ##
===============================================
- Coverage 75.05% 67.97% -7.09%
===============================================
Files 280 275 -5
Lines 43856 66952 +23096
===============================================
+ Hits 32918 45510 +12592
- Misses 10938 21442 +10504
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
apoorvdeshmukh
approved these changes
Jun 16, 2026
paulmedynski
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #4363 (0764a5c) into
release/7.0.