Trim XML documentation for reference project + fix Note tags - #3233
#3233Merged
Merged
Trim XML documentation for reference project + fix Note tags#3233
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3233 +/- ##
==========================================
+ Coverage 72.81% 73.04% +0.23%
==========================================
Files 297 296 -1
Lines 59661 57257 -2404
==========================================
- Hits 43440 41825 -1615
+ Misses 16221 15432 -789
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cheenamalhotra
marked this pull request as ready for review
April 4, 2025 22:52
paulmedynski
requested changes
Apr 7, 2025
paulmedynski
left a comment
Contributor
There was a problem hiding this comment.
Some formatting and a couple of questions.
mdaigle
reviewed
Apr 8, 2025
paulmedynski
requested changes
Apr 10, 2025
paulmedynski
left a comment
Contributor
There was a problem hiding this comment.
I think the tab -> space work is still outstanding.
Member
Author
Changed all to spaces. |
paulmedynski
approved these changes
Apr 14, 2025
samsharma2700
approved these changes
Apr 14, 2025
cheenamalhotra
added a commit
that referenced
this pull request
Apr 16, 2025
cheenamalhotra
added a commit
that referenced
this pull request
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3228
Modified:
<note>tags are not recognized by mdoc that generates .NET API Reference documentation, hence reverted them back to Markdown formatted notes.These changes have been validated at the API Docs PR: https://github.com/dotnet/sqlclient-api-docs/pull/79, I will be backporting them to release/6.0 and republishing 6.0.2 specific changes.