[5.1] Sync ref project references with runtime projects - #3153
#3153Closed
edwardneal wants to merge 1 commit into
dotnet:release/5.1dotnet/SqlClient:release/5.1from
edwardneal:port/5.1/sync-ref-project-dependenciesedwardneal/SqlClient:port/5.1/sync-ref-project-dependenciesCopy head branch name to clipboard
Closed
[5.1] Sync ref project references with runtime projects#3153edwardneal wants to merge 1 commit intodotnet:release/5.1dotnet/SqlClient:release/5.1from edwardneal:port/5.1/sync-ref-project-dependenciesedwardneal/SqlClient:port/5.1/sync-ref-project-dependenciesCopy head branch name to clipboard
edwardneal wants to merge 1 commit into
dotnet:release/5.1dotnet/SqlClient:release/5.1from
edwardneal:port/5.1/sync-ref-project-dependenciesedwardneal/SqlClient:port/5.1/sync-ref-project-dependenciesCopy head branch name to clipboard
Conversation
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
benrr101
approved these changes
Feb 19, 2025
benrr101
left a comment
Contributor
There was a problem hiding this comment.
Tbh I don't want to see the ref projects ever again, so anything that touches them is probably fine 😅
mdaigle
approved these changes
Feb 19, 2025
Contributor
|
@edwardneal sorry for the annoyances on this stuff... the secrets things has been a real pain for everyone and I also think our branching strategy contributes to the pain. We were discussing this PR at triage today and came up with two options:
Since we don't intend to backport many changes to these branches, we're going to take the second option. Hopefully that's not a huge issue - I'll make sure you still get the credit for the commits! |
Contributor
Author
|
That sounds good to me, thanks @benrr101! |
Contributor
|
Closing in favor of #3180 to pick up full CI run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports #2878 and #3124.
Fixes #2541. Fixes #2082.