Enhance TDS Login ClientInterfaceName field with client info - #3149
#3149Merged
paulmedynski merged 6 commits intoMar 4, 2025
maindotnet/SqlClient:mainfrom
dev/paul/driver-name-telemetrydotnet/SqlClient:dev/paul/driver-name-telemetryCopy head branch name to clipboard
Merged
Enhance TDS Login ClientInterfaceName field with client info#3149paulmedynski merged 6 commits intomaindotnet/SqlClient:mainfrom dev/paul/driver-name-telemetrydotnet/SqlClient:dev/paul/driver-name-telemetryCopy head branch name to clipboard
paulmedynski merged 6 commits into
maindotnet/SqlClient:mainfrom
dev/paul/driver-name-telemetrydotnet/SqlClient:dev/paul/driver-name-telemetryCopy head branch name to clipboard
Conversation
Contributor
Author
|
@dotnet-policy-service agree company="Microsoft" |
ErikEJ
reviewed
Feb 11, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3149 +/- ##
==========================================
- Coverage 72.93% 72.80% -0.14%
==========================================
Files 287 288 +1
Lines 59173 59246 +73
==========================================
- Hits 43160 43136 -24
- Misses 16013 16110 +97
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
saurabh500
reviewed
Feb 13, 2025
saurabh500
approved these changes
Feb 13, 2025
saurabh500
left a comment
Contributor
There was a problem hiding this comment.
Left some comments. Functionality looks good.
David-Engel
approved these changes
Feb 14, 2025
saurabh500
approved these changes
Feb 14, 2025
Contributor
Author
|
The spec has moved here: The OS Info and RuntimeInfo fields have been simplified to have a max length of 44 Unicode characters each, with no efforts to share the remaining space. The latest commit matches that. |
paulmedynski
commented
Feb 26, 2025
…face class. - Added tests for ClientInterface. - Reverted changes to Application Name. - Removed unnecessary SQP_PROVIDER_NAME constant.
- Addressed review comments: - Converted type/member documentation to C# XML style. - Added constants for OS types and max lengths. - Renamed Trunc() to Truncate(). - Added copyright headers.
- Updated Driver Name and Arch max lengths per updated spec.
- Avoided Architecture test that doesn't compile in .NET Framework.
- Removed length sharing logic for OS and Runtime Info. - Replaced with simple max len of 44 for each field.
paulmedynski
force-pushed
the
dev/paul/driver-name-telemetry
branch
from
March 4, 2025 13:40
921f70b to
cf328d1
Compare
- Added a unit test to check the Client Interface Name the driver sends in the LOGIN7 packet.
cheenamalhotra
approved these changes
Mar 4, 2025
paulmedynski
added a commit
that referenced
this pull request
Mar 5, 2025
- Moved logic to build client interface name into its own ClientInterface class. - Added tests for ClientInterface. - Reverted changes to Application Name. - Removed unnecessary SQP_PROVIDER_NAME constant.
cheenamalhotra
pushed a commit
that referenced
this pull request
Mar 5, 2025
…ent info (#3200) * Enhance TDS Login ClientInterfaceName field with client info (#3149) - Moved logic to build client interface name into its own ClientInterface class. - Added tests for ClientInterface. - Reverted changes to Application Name. - Removed unnecessary SQP_PROVIDER_NAME constant. * User Story 33291: Enhance client interface value sent with login - Fixed vulnerable transitive dependencies. * User Story 33291: Enhance client interface value sent with login - Removed duplicate System.Text.Json version.
cheenamalhotra
added a commit
that referenced
this pull request
Mar 14, 2025
paulmedynski
added a commit
that referenced
this pull request
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec is here: https://microsoft-my.sharepoint.com/:w:/p/davidengel/EVybTpCmdQZGixv9r-qzXYQBl-Jp4HH1GGAE6oWxh0DqhQ?e=d0b0uP