Align comments between netfx and netcore codebases - #2966
#2966Merged
cheenamalhotra merged 1 commit intoNov 6, 2024
dotnet:maindotnet/SqlClient:mainfrom
MichelZ:merge-sqldatareader-commentsMichelZ/SqlClient:merge-sqldatareader-commentsCopy head branch name to clipboard
Merged
Align comments between netfx and netcore codebases#2966cheenamalhotra merged 1 commit intodotnet:maindotnet/SqlClient:mainfrom MichelZ:merge-sqldatareader-commentsMichelZ/SqlClient:merge-sqldatareader-commentsCopy head branch name to clipboard
cheenamalhotra merged 1 commit into
dotnet:maindotnet/SqlClient:mainfrom
MichelZ:merge-sqldatareader-commentsMichelZ/SqlClient:merge-sqldatareader-commentsCopy head branch name to clipboard
Conversation
benrr101
requested changes
Nov 4, 2024
benrr101
left a comment
Contributor
There was a problem hiding this comment.
Please rollback the change for EditorBrowsableAttribute if we don't have a strong reason to move it over.
Also, in the future, please just combine all the comment cleanup changes into a single PR.
benrr101
approved these changes
Nov 5, 2024
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mdaigle
approved these changes
Nov 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2966 +/- ##
==========================================
- Coverage 72.31% 72.29% -0.03%
==========================================
Files 288 288
Lines 59660 59660
==========================================
- Hits 43145 43133 -12
- Misses 16515 16527 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully an easy to review PR that deals with differences in comments and some whitespace between netfx and netcore for easier future merging
Part of #2965