Merged
Remove ProjectReference item to inner project except in graph builds#847
Conversation
This should avoid the vast majority of the P2P problems introduced by trying to work in `msbuild -graph -isolate`.
…eting framework error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By removing the ProjectReference item that pointed to our cached inner build, we can avoid all the bugs that have been streaming in since adding it, due to project types that assume they understand all P2Ps.
We still produce that item with a different item type for our own use, and we copy that into a ProjectReference item for graph builds so that NB.GV is doing the Right Thing in that case.
Closes #845
Closes #844