Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

bom update #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
denis-yuen merged 5 commits into from
Aug 24, 2023
Merged

bom update #254

denis-yuen merged 5 commits into from
Aug 24, 2023

Conversation

@denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented Aug 22, 2023 •
edited
Loading

Description
Investigating the issue with #253
Splitting the difference on the bom update

Review Instructions
n/a except that regular (non-cron) builds should include the 1.15.0-alpha.5 bom and other parts of dockstore

Issue
n/a but split out from #253

Two follow-up issues:

  1. Nightly cron doesn't seem to work to detect some changes in the webservice (but it works with others). Possibly compilation issues are detected, but not changes in jars? https://ucsc-cgl.atlassian.net/browse/SEAB-5853
  2. Re-enable disabled tests (a bunch of checker workflow tests, one hosted workflow test) https://ucsc-cgl.atlassian.net/browse/SEAB-5854

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running ./mvnw clean install
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Aug 22, 2023
@denis-yuen
Copy link
Member Author

denis-yuen commented Aug 22, 2023 •
edited
Loading

Going down weird rabbit holes.
Some errors appear to be changes in how the webservice responds to requests (think the nightly jobs would have caught that)
Others seem to be an issue with the webservice getting the wrong results from the DB?

In all cases, the tests are dying with exit codes which makes it hard to debug

@denis-yuen
Copy link
Member Author

denis-yuen commented Aug 23, 2023

At this point, we've identified the tests needed to be disabled to get the builds working with 1.15.0-alpha.2

@codecov
Copy link

codecov bot commented Aug 23, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.46% 🎉

Comparison is base (7539c18) 69.71% compared to head (df4e542) 70.18%.

Additional details and impacted files 
@@              Coverage Diff              @@
##             develop     #254      +/-   ##
=============================================
+ Coverage      69.71%   70.18%   +0.46%     
- Complexity      1038     1052      +14     
=============================================
  Files             47       47              
  Lines           6070     6070              
  Branches         799      799              
=============================================
+ Hits            4232     4260      +28     
+ Misses          1482     1472      -10     
+ Partials         356      338      -18
Flag Coverage Δ
bitbuckettests 9.83% <ø> (ø)
confidentialtooltests 55.65% <ø> (-0.19%) ⬇️
confidentialworkflowtests 30.21% <ø> (+5.35%) ⬆️
nonconfidentialtests 32.28% <ø> (-0.12%) ⬇️
singularitytests 16.58% <ø> (ø)
unittests 8.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@denis-yuen
Copy link
Member Author

denis-yuen commented Aug 23, 2023

Locally confirmed, the same tests needed to be disabled to get the builds working with 1.15.0-alpha.5

@denis-yuen denis-yuen marked this pull request as ready for review August 23, 2023 18:20
@denis-yuen denis-yuen requested review from a team, coverbeck, david4096, hyunnaye, kathy-t, svonworl and y-ng and removed request for a team August 23, 2023 18:27
@denis-yuen denis-yuen mentioned this pull request Aug 23, 2023
Merged
2 tasks
@denis-yuen denis-yuen merged commit 1a5d4a6 into develop Aug 24, 2023
@denis-yuen denis-yuen deleted the feature/pom_update branch August 24, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@david4096 david4096 Awaiting requested review from david4096 david4096 was automatically assigned from dockstore/dockstore

@hyunnaye hyunnaye Awaiting requested review from hyunnaye hyunnaye was automatically assigned from dockstore/dockstore

@y-ng y-ng Awaiting requested review from y-ng y-ng was automatically assigned from dockstore/dockstore

@svonworl svonworl Awaiting requested review from svonworl

2 more reviewers

@coverbeck coverbeck coverbeck approved these changes

@kathy-t kathy-t kathy-t approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@denis-yuen denis-yuen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@denis-yuen @coverbeck @kathy-t
Morty Proxy This is a proxified and sanitized view of the page, visit original site.