fix cron build #253
Merged
fix cron build #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
FYI @kathy-t (there's also something else afoot, looking into it) |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #253 +/- ##
=============================================
- Coverage 70.29% 70.26% -0.04%
+ Complexity 1069 1052 -17
=============================================
Files 47 47
Lines 6070 6070
Branches 799 799
=============================================
- Hits 4267 4265 -2
Misses 1467 1467
- Partials 336 338 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
denis-yuen
commented
Aug 24, 2023
| // the following change the DB state | ||
| workflowApi.handleGitHubRelease("refs/heads/main", INSTALLATION_ID, WORKFLOW_REPO, USER_2_USERNAME); | ||
|
|
||
| PushPayload pushPayload = new PushPayload().ref("refs/heads/main"); |
Member
Author
There was a problem hiding this comment.
The only "real" change now with the bom update split out
(and certain tests skipped)
|
Kudos, SonarCloud Quality Gate passed!
|
svonworl
approved these changes
Aug 24, 2023
kathy-t
approved these changes
Aug 24, 2023
Contributor
kathy-t
left a comment
There was a problem hiding this comment.
Thanks for tackling this
coverbeck
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seeing
dockstore-cli/.github/workflows/cron.yml has failed!in #dockstore-dev-infoFollow-up on dockstore/dockstore#5626
PR review after #254 is merged
Review Instructions
Check nightly cron
Issue
SEAB-5781
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
./mvnw clean install