Add templates for Python 2.7#315
Merged
Merged
Add templates for Python 2.7#315
Conversation
(This allows us to generate ~10 files from 4, which is a pretty decent ratio IMO -- it also helped me catch a few bits I missed previously.)
yosifkit
approved these changes
Jul 20, 2018
yosifkit
left a comment
Member
There was a problem hiding this comment.
Since 2.7-slim-stretch is the only one with material changes, we are good to merge once it is green.
| [ -z "$fail" ] || { echo >&2 "error: cannot find a suitable version for 'vimdiff' on '$version/$v/Dockerfile'"; exit 1; } | ||
| else | ||
| { generated_warning; cat "$template"; } > "$dir/Dockerfile" | ||
| template="caveman-${template}" |
tao12345666333
approved these changes
Jul 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This allows us to generate ~10 files from 4, which is a pretty decent ratio IMO -- it also helped me catch a few bits I missed previously.)
Hopefully now @yosifkit will stop complaining at me every time he updates Python (not to mention my own cursing). 😄 😇