Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

2.7/alpine3.7: Add nis libraries now that 2.7.15 is patched#281

Merged
tianon merged 2 commits into
docker-library:masterdocker-library/python:masterfrom
JayH5:py2.7-alpine3.7-nisJayH5/python:py2.7-alpine3.7-nisCopy head branch name to clipboard
Jun 5, 2018
Merged

2.7/alpine3.7: Add nis libraries now that 2.7.15 is patched#281
tianon merged 2 commits into
docker-library:masterdocker-library/python:masterfrom
JayH5:py2.7-alpine3.7-nisJayH5/python:py2.7-alpine3.7-nisCopy head branch name to clipboard

Conversation

@JayH5

@JayH5 JayH5 commented Apr 30, 2018

Copy link
Copy Markdown
Contributor

The final fix for #247.

libffi-dev \
libnsl-dev \
openssl \
openssl-dev \

@JayH5 JayH5 Apr 30, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this now makes the openssl libs "unsorted", but the openssl builds should go away soon. Alpine 3.4 is being deprecated has been removed and Alpine 3.8's libressl should be supported by Python 3.7.

@yosifkit yosifkit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding libnsl and libtirpc seems fine to me since this follows the same logic used in the python:3.x images:

python/update.sh

Lines 162 to 164 in f38c92b

if [[ "$variant" == alpine* ]] && [[ "$variant" != alpine3.7 ]]; then
sed -ri -e '/libnsl-dev/d' -e '/libtirpc-dev/d' "$dir/Dockerfile"
fi

Sorting of ssl library is fine as well (more correct in more places).

@yosifkit

yosifkit commented Jun 4, 2018

Copy link
Copy Markdown
Member

Size difference for reference

REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE
python              2.7-alpine-test        bd330d7bf7a9        28 minutes ago      74.5MB
python              2.7-alpine3.7          ced9a5c17e81        4 weeks ago         69.8MB

@tianon tianon merged commit bbbc37f into docker-library:master Jun 5, 2018
@tianon

tianon commented Jun 5, 2018

Copy link
Copy Markdown
Member

Also relevant: https://github.com/tiran/peps/blob/ba2635cb59cd97264905ce32ef85f9456c1a5297/pep-9999.rst#nis (movement in Python upstream to remove nis entirely)

tianon added a commit to infosiftr/stackbrew that referenced this pull request Jun 5, 2018
- `bash`: 4.4.23
- `ghost`: 1.23.1
- `julia`: 0.6.3
- `matomo`: GPG race conditions (matomo-org/docker#105)
- `memcached`: `extstore` (docker-library/memcached#38)
- `mongo`: 4.0.0~rc2
- `openjdk`: remove 9 (docker-library/openjdk#199), add 10 for Windows (docker-library/openjdk#200), 11-ea+16
- `owncloud`: update PECL exts (docker-library/owncloud#102)
- `percona`: 5.7.22, 5.6.40
- `php`: fix `wget: error getting response: Connection reset by peer`
- `piwik`: GPG race conditions (matomo-org/docker#105)
- `python`: add `nis` nonsense to 2.7 (docker-library/python#281), 3.7.0b5
- `rocket.chat`: 0.65.1
- `ruby`: 2.6.0-preview2
- `wordpress`: update GPG for wp-cli
tao12345666333 pushed a commit to tao12345666333/python that referenced this pull request Jun 28, 2018
2.7/alpine3.7: Add nis libraries now that 2.7.15 is patched
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.