Fix #682 - Add LogPath to docker inspect response#683
Fix #682 - Add LogPath to docker inspect response#683KostyaSha merged 4 commits intodocker-java:masterdocker-java/docker-java:masterfrom jkubrynski:682-logpath-inspectjkubrynski/docker-java:682-logpath-inspectCopy head branch name to clipboard
Conversation
|
Could you create some test case? |
| private String hostsPath; | ||
|
|
||
| @JsonProperty("LogPath") | ||
| private String logPath; |
There was a problem hiding this comment.
It's present since I remember. Even in your test inspectContainerResponse_full.json there is LogPath element
There was a problem hiding this comment.
Please try check whether it exist before 1.19 at least and place javadoc.
There was a problem hiding this comment.
If it already exists in existing json samples, then extend deserialisation test case with check.
There was a problem hiding this comment.
LogPath was for sure in 1.18
There was a problem hiding this comment.
Please place javadoc @since ~ >1.17
…after code review
| assertEquals(response.getVolumesRW()[1].getVolume().getPath(), "/bar/foo/myvol2"); | ||
| assertFalse(response.getVolumesRW()[1].getAccessMode().toBoolean()); | ||
| assertTrue(response.getVolumesRW()[0].getAccessMode().toBoolean()); | ||
| assertEquals(response.getLogPath(), "/mnt/sda1/var/lib/docker/containers/469e5edd8d5b33e3c905a7ffc97360ec6ee211d6782815fbcd144568045819e1/469e5edd8d5b33e3c905a7ffc97360ec6ee211d6782815fbcd144568045819e1-json.log"); |
There was a problem hiding this comment.
Bad example was before...
assertThat(response.getLogPath(), is("/mnt/sda1/var/lib/docker/containers/469e5edd8d5b33e3c905a7ffc97360ec6ee211d6782815fbcd144568045819e1/469e5edd8d5b33e3c905a7ffc97360ec6ee211d6782815fbcd144568045819e1-json.log")
…test assertion
|
Retriggering PR build |
…java#683) * Fix docker-java#682 - Add LogPath to docker inspect response * Fix docker-java#682 - Add LogPath to docker inspect response - fixes after code review * Fix docker-java#682 - Add LogPath to docker inspect response - add javadoc * Fix docker-java#682 - Add LogPath to docker inspect response - clean test assertion
This change is