Fix for #670#680
Fix for #670#680KostyaSha merged 1 commit intodocker-java:masterdocker-java/docker-java:masterfrom tejksat:fixLoadImageFromTarFailstejksat/docker-java:fixLoadImageFromTarFailsCopy head branch name to clipboard
Conversation
|
It could be fixed with this check or it could be a new |
| channel.pipeline().addLast(new JsonObjectDecoder()); | ||
| channel.pipeline().addLast(jsonResponseHandler); | ||
|
|
||
| if (!Void.class.equals(typeReference.getType())) { |
There was a problem hiding this comment.
I would rather refractor and extract a specific method without JSON mapping. I'll do it in the nearest days.
|
hello world still fails on first run :E but seems loadimage test fixed. |
3b154a9 to
548b247
Compare
JSON decoding disabled on /images/load command execution.
548b247 to
cc8dbea
Compare
|
@tejksat mmm... maybe it could be combined with #664 ? But i tried to make #664 with JsonParsed content and broke current quiet call. So probably we can offer 2 different callbacks for end-users so they can choose them self what to use for what mix of arguments? |
|
Merging this as it fixes test for |
JSON decoding disabled on /images/load command execution.
JSON decoding disabled when response body is not expected to be parsed as a JSON.
This change is