Add unrecognizedFields to Task#1616
Closed
regbo wants to merge 2 commits into
Closed
Add unrecognizedFields to Task#1616regbo wants to merge 2 commits into
regbo wants to merge 2 commits into
Conversation
Add unrecognizedFields
Member
|
@regbo thanks! That's something I wanted to do for a long time. We definitely should add it to every model. Perhaps we should even add a common parent class (e.g. Could you please do it as part of this PR? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the task class does not contain the NetworksAttachments field.
As a stop gap, wouldn't it make sense for all models to implement the unrecognizedFields logic below? That way if the Docker API changes the content will be captured?