Compile each file match pattern only once#1411
Closed
swiedenfeld wants to merge 2 commits into
docker-java:masterdocker-java/docker-java:masterfrom
swiedenfeld:compile_less_patternsCopy head branch name to clipboard
Closed
Compile each file match pattern only once#1411swiedenfeld wants to merge 2 commits intodocker-java:masterdocker-java/docker-java:masterfrom swiedenfeld:compile_less_patternsCopy head branch name to clipboard
swiedenfeld wants to merge 2 commits into
docker-java:masterdocker-java/docker-java:masterfrom
swiedenfeld:compile_less_patternsCopy head branch name to clipboard
Conversation
Contributor
Author
|
Duplicates #1412 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran a profiler to analyse performance of
ScannedResult # addFilesInDirectoryin the scenario described in #1409. All ignore strings must be matched on each of the +60k files, and a not neglible amount of time is spent compiling the Strings fromignoresinto patterns over and over again. It seems sensible to cache already compiled patterns into a map for quick resolution.Unfortunately, it does not improve the situation in #1409 too much. The majority of processing time is spent walking the directory tree, which is possibly bound by I/O.