Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add resize container and exec command#1262

Merged
bsideup merged 6 commits into
docker-java:masterdocker-java/docker-java:masterfrom
creaink:resizecreaink/docker-java:resizeCopy head branch name to clipboard
Jun 8, 2020
Merged

Add resize container and exec command#1262
bsideup merged 6 commits into
docker-java:masterdocker-java/docker-java:masterfrom
creaink:resizecreaink/docker-java:resizeCopy head branch name to clipboard

Conversation

@creaink

@creaink creaink commented Oct 15, 2019

Copy link
Copy Markdown
Contributor

Improve resize exec test and adapt project struct for #1106


This change is Reviewable

Comment thread docker-java/src/test/java/com/github/dockerjava/cmd/ResizeExecCmdIT.java Outdated
@bsideup

bsideup commented May 29, 2020

Copy link
Copy Markdown
Member

@creaink could you please sync with master?

creaink and others added 3 commits May 29, 2020 18:13
Comment thread docker-java/src/test/java/com/github/dockerjava/cmd/ResizeExecCmdIT.java Outdated
Comment thread docker-java/src/test/java/com/github/dockerjava/cmd/ResizeContainerCmdIT.java Outdated
Comment thread docker-java/src/test/java/com/github/dockerjava/cmd/ResizeExecCmdIT.java Outdated
Comment thread docker-java/src/test/java/com/github/dockerjava/cmd/ResizeExecCmdIT.java Outdated
Comment thread docker-java/src/test/java/com/github/dockerjava/cmd/ResizeExecCmdIT.java Outdated
Comment thread docker-java/src/test/java/com/github/dockerjava/cmd/ResizeContainerCmdIT.java Outdated
@bsideup bsideup added this to the next milestone Jun 8, 2020
@bsideup bsideup merged commit e1586cc into docker-java:master Jun 8, 2020
@bsideup

bsideup commented Jun 8, 2020

Copy link
Copy Markdown
Member

@creaink merged! Thank you!

@creaink

creaink commented Jun 8, 2020

Copy link
Copy Markdown
Contributor Author

@bsideup when I run test case on my computer, even I set environment variable like DOCKER_HOST.But it still require docker-java.properties. It is a bug or something?

@bsideup

bsideup commented Jun 8, 2020

Copy link
Copy Markdown
Member

@creaink please share more info. How does it require? Throws an error or something? Also, which OS are you using?

@creaink

creaink commented Jun 8, 2020

Copy link
Copy Markdown
Contributor Author

@creaink please share more info. How does it require? Throws an error or something? Also, which OS are you using?

OK, I will submit a issue with more detail about this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.