allocator: Fix stuck tasks at startup#1938
Merged
cyli merged 1 commit intoFeb 8, 2017
moby:mastermoby/swarmkit:masterfrom
aaronlehmann:allocator-stuck-tasksaaronlehmann/swarmkit:allocator-stuck-tasksCopy head branch name to clipboard
Merged
allocator: Fix stuck tasks at startup#1938cyli merged 1 commit intomoby:mastermoby/swarmkit:masterfrom aaronlehmann:allocator-stuck-tasksaaronlehmann/swarmkit:allocator-stuck-tasksCopy head branch name to clipboard
cyli merged 1 commit into
moby:mastermoby/swarmkit:masterfrom
aaronlehmann:allocator-stuck-tasksaaronlehmann/swarmkit:allocator-stuck-tasksCopy head branch name to clipboard
Conversation
If the allocator starts up and sees a task in the NEW state that doesn't need allocations, it should move it to PENDING immediately. There was code in place for this but it wasn't actually updating the task's state. The task would get stuck and never get assigned. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
Codecov Report@@ Coverage Diff @@
## master #1938 +/- ##
==========================================
- Coverage 54.15% 54.11% -0.04%
==========================================
Files 108 108
Lines 18544 18536 -8
==========================================
- Hits 10042 10031 -11
+ Misses 7284 7275 -9
- Partials 1218 1230 +12Continue to review full report at Codecov.
|
Contributor
|
LGTM, thanks for fixing so quickly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the allocator starts up and sees a task in the NEW state that doesn't
need allocations, it should move it to PENDING immediately.
There was code in place for this but it wasn't actually updating the
task's state. The task would get stuck and never get assigned.
ping @cyli