Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[17.09] Disable hostname lookup on chain exists check #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thaJeztah
Copy link
Member

cherry-pick of #1974 for 17.09

git checkout -b 17.09-backport-iptables_no_dns_lookup upstream/bump_17.09
git cherry-pick -s -S -x 8dce207dddc3f805b852088a60cc27bfe54b065e

Without -n, iptables will attempt to lookup hostnames for IP
addresses, which can slow down the call dramatically.
Since we don't need this, and generally don't even care about the
output, use the -n flag to disable this.

(cherry picked from commit 8dce207)

Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Without `-n`, iptables will attempt to lookup hostnames for IP
addresses, which can slow down the call dramatically.
Since we don't need this, and generally don't even care about the
output, use the `-n` flag to disable this.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
(cherry picked from commit 8dce207)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the 17.09-backport-iptables_no_dns_lookup branch from 4b4ced5 to 5c9dec8 Compare November 20, 2017 19:48
@fcrisciani
Copy link

LGTM

@fcrisciani fcrisciani merged commit ca1f761 into moby:bump_17.09 Nov 20, 2017
@thaJeztah thaJeztah deleted the 17.09-backport-iptables_no_dns_lookup branch November 20, 2017 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.