Disable hostname lookup on chain exists check #1974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without `-n`, iptables will attempt to lookup hostnames for IP addresses, which can slow down the call dramatically. Since we don't need this, and generally don't even care about the output, use the `-n` flag to disable this. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #1974 +/- ##
=========================================
Coverage ? 38.49%
=========================================
Files ? 137
Lines ? 27351
Branches ? 0
=========================================
Hits ? 10530
Misses ? 15524
Partials ? 1297
Continue to review full report at Codecov.
|
mavenugo
approved these changes
Oct 7, 2017
|
@mavenugo can you add some label so that we don't miss the backport? |
This was referenced Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without
-n, iptables will attempt to lookup hostnames for IPaddresses, which can slow down the call dramatically.
Since we don't need this, and generally don't even care about the
output, use the
-nflag to disable this.Signed-off-by: Brian Goff cpuguy83@gmail.com