Do not add names to ingress network#1489
Do not add names to ingress network#1489
Conversation
|
LGTM |
|
@mrjana If a service publishes a port and is attached to a user created overlay network we prefer that network in the name resolution and not the I think this change can be made after we block the service creation on the ingress network. Otherwise the behavior will be confusing. wdyt ? AFAIK, our documentation doesn't mention that service creation on ingress network is not recommended/supported. |
Do not add service discovery names to ingress network as this is a routing only network and no intra-cluster discovery should happen in that network. This fixes the ambiguity and resolving names between services which are both publishing ports and also attached to same another network. Signed-off-by: Jana Radhakrishnan <mrjana@docker.com>
|
@sanimej Ah yes, I totally forgot about that fix you made for preferring user defined network. But nevertheless, there are still some issues with creating name entries in the ingress network and it is totally unnecessary. We never intended ingress network to be used the way it is being used and we should block. There is multiple PRs underway at the moment to fix this unintended ingress network behavior. This is part of them. |
|
👍 |
cherry-picking moby/swarmkit#1600 and moby/libnetwork#1489 Signed-off-by: Madhu Venugopal <madhu@docker.com>
Do not add service discovery names to ingress network as this is a
routing only network and no intra-cluster discovery should happen in
that network. This fixes the ambiguity and resolving names between
services which are both publishing ports and also attached to same
another network.
Related to moby/moby#27147
Signed-off-by: Jana Radhakrishnan mrjana@docker.com