do not allow sub second in healthcheck options in Dockerfile#31177
Merged
thaJeztah merged 1 commit intomoby:mastermoby/moby:masterfrom Mar 8, 2017
allencloud:donot-allow-subsecond-in-dockerfile-healthcheckallencloud/docker:donot-allow-subsecond-in-dockerfile-healthcheckCopy head branch name to clipboard
Merged
do not allow sub second in healthcheck options in Dockerfile#31177thaJeztah merged 1 commit intomoby:mastermoby/moby:masterfrom allencloud:donot-allow-subsecond-in-dockerfile-healthcheckallencloud/docker:donot-allow-subsecond-in-dockerfile-healthcheckCopy head branch name to clipboard
thaJeztah merged 1 commit intomoby:mastermoby/moby:masterfrom
allencloud:donot-allow-subsecond-in-dockerfile-healthcheckallencloud/docker:donot-allow-subsecond-in-dockerfile-healthcheckCopy head branch name to clipboard
Conversation
Signed-off-by: allencloud <allen.sun@daocloud.io>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: allencloud allen.sun@daocloud.io
This is a follow-up for #30203
Since in docker/master, we do not allow docker daemon to validate healthcheck parameter
TimeoutandIntervalto be not less than 1 second. We discussed about that we should not supportsub second validation.Without this PR, if a user specifies
Timeoutin Dockerfile to be 0.5s(sub second), then thedocker buildwill be OK, and let us call the built image to bebuilt-image. However, thedocker run built-imagewill report error, since PR #30203.- What I did
TimeoutandIntervalin Dockerfile options.ping @cpuguy83 @LK4D4