validate healthcheck params in daemon side#30203
validate healthcheck params in daemon side#30203cpuguy83 merged 1 commit intomoby:mastermoby/moby:masterfrom allencloud:validate-healthcheck-params-in-daemon-sideallencloud/docker:validate-healthcheck-params-in-daemon-sideCopy head branch name to clipboard
Conversation
19f76c9 to
131d5ef
Compare
6b6f784 to
eee33a9
Compare
There was a problem hiding this comment.
I think this should validate less than 1s, wdyt as I don't think we can guarantee sub-second checking.
There was a problem hiding this comment.
If that, maybe we need to use a consistent validation in the whole procedure. I think there are three places to validate:
- client side;
- daemon received parameters from API;
- parameters from dockerfile when building
I think consistency is the first thing(no matter less than 0 or less than 1s), the second thing to add more specific explanation in docs.
But currently, I am on less than 0. 😄 Open for input.
There was a problem hiding this comment.
Sure, consistent is good, but the daemon side is the "important" piece.
I just think if we are going to add a validation, let's make sure it's not letting non-sensical values.
|
@cpuguy83 there is question for you here :) |
dc8c202 to
6ce0fed
Compare
49df201 to
b88b9a8
Compare
Signed-off-by: allencloud <allen.sun@daocloud.io>
b88b9a8 to
e399c55
Compare
|
LGTM |
…rams-in-daemon-side validate healthcheck params in daemon side
Signed-off-by: allencloud allen.sun@daocloud.io
fixes #30202
validate user input healthcheck parameters via API in the daemon side.
- What I did
--health-retriesvalidation in client side- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)