pkg: idtools: fix subid files parsing#20725
Merged
vdemeester merged 1 commit intoFeb 26, 2016
moby:mastermoby/moby:masterfrom
runcom:fix-subid-files-parsingruncom/docker:fix-subid-files-parsingCopy head branch name to clipboard
Merged
pkg: idtools: fix subid files parsing#20725vdemeester merged 1 commit intomoby:mastermoby/moby:masterfrom runcom:fix-subid-files-parsingruncom/docker:fix-subid-files-parsingCopy head branch name to clipboard
vdemeester merged 1 commit into
moby:mastermoby/moby:masterfrom
runcom:fix-subid-files-parsingruncom/docker:fix-subid-files-parsingCopy head branch name to clipboard
Conversation
Member
Author
|
This bug was here before 1.10.0, however this is failing distros like Fedora who ships comments in those files (which will be fixed in later versions of |
runcom
force-pushed
the
fix-subid-files-parsing
branch
from
February 26, 2016 13:59
4e4701b to
d747283
Compare
Member
|
LGTM I'll add it to the 1.10.3 milestone, but we probably won't have a 1.10.3 |
Member
|
LGTM |
runcom
force-pushed
the
fix-subid-files-parsing
branch
from
February 26, 2016 14:22
d747283 to
503b262
Compare
Member
Author
|
test seems not ok, on it |
runcom
force-pushed
the
fix-subid-files-parsing
branch
3 times, most recently
from
February 26, 2016 14:39
dad7000 to
83a1d20
Compare
Member
Author
|
alright test now works (test name was not capital after Test*) and so it wasn't executed, w/o this patch the test successfully fails: moving again to merge |
Contributor
|
Thanks @runcom! |
Since Docker is already skipping newlines in /etc/sub{uid,gid},
this patch skips commented out lines - otherwise Docker fails to start.
Add unit test also.
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
runcom
force-pushed
the
fix-subid-files-parsing
branch
from
February 26, 2016 14:43
83a1d20 to
bf04d68
Compare
Member
Author
|
@estesp :) |
vdemeester
added a commit
that referenced
this pull request
Feb 26, 2016
pkg: idtools: fix subid files parsing
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/etc/sub{uid,gid} files can contain #-prefixed lines that are comments.
Fix those files parsing by skipping commented out lines. Add regression
unit test also.
ping @estesp
Signed-off-by: Antonio Murdaca runcom@redhat.com