WIP: cli/command/container: add create/run --umask - #7108
#7108Open
zhangyoufu wants to merge 2 commits into
Open
WIP: cli/command/container: add create/run --umask#7108zhangyoufu wants to merge 2 commits into
zhangyoufu wants to merge 2 commits into
Conversation
Signed-off-by: Youfu Zhang <zhangyoufu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker runto set umask in container moby/moby#19189- What I did
add create/run --umask flag, w/ some test cases
- How I did it
OCI runtime spec supports Umask since 2019, see opencontainers/runtime-spec@6b04c63
I just add HostConfig.Umask field in moby, then add CLI flag in docker/cli.
- How to verify it
docker run --rm --umask 1 alpine sh -c umask
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)