Merged
feat: use schema-ed json as default to_dict/json#57
Conversation
JoanFM
reviewed
Jan 17, 2022
JoanFM
left a comment
Member
There was a problem hiding this comment.
Please add test validating that embeddings are properly handled
Codecov Report
@@ Coverage Diff @@
## main #57 +/- ##
==========================================
+ Coverage 82.75% 82.92% +0.16%
==========================================
Files 70 70
Lines 3329 3350 +21
==========================================
+ Hits 2755 2778 +23
+ Misses 574 572 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
Author
|
do you know that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #56