fix: dict method for document view - #1559
#1559Merged
Merged
fix: dict method for document view#1559
Conversation
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
samsja
reviewed
May 22, 2023
samsja
reviewed
May 22, 2023
samsja
reviewed
May 22, 2023
samsja
reviewed
May 22, 2023
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
Signed-off-by: Johannes Messner <messnerjo@gmail.com>
samsja
approved these changes
May 22, 2023
|
📝 Docs are deployed on https://ft-fix-todict-docview--jina-docs.netlify.app 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this, calling
doc.dict()whendoc.is_view() == Truewould return an empty dict.The core issue is that the
ColumnStorageViewdid not behave like a proper dict:.values()and.keys()were not implemented, and would return empty values.That is fixed in this PR.