feat: make DocList an actual Python List - #1457
#1457Merged
JoanFM merged 17 commits intoApr 27, 2023
maindocarray/docarray:mainfrom
feat-make-doclist-a-listdocarray/docarray:feat-make-doclist-a-listCopy head branch name to clipboard
Merged
feat: make DocList an actual Python List#1457JoanFM merged 17 commits intomaindocarray/docarray:mainfrom feat-make-doclist-a-listdocarray/docarray:feat-make-doclist-a-listCopy head branch name to clipboard
JoanFM merged 17 commits into
maindocarray/docarray:mainfrom
feat-make-doclist-a-listdocarray/docarray:feat-make-doclist-a-listCopy head branch name to clipboard
Conversation
JoanFM
force-pushed
the
feat-make-doclist-a-list
branch
2 times, most recently
from
April 26, 2023 13:56
f7a713f to
162bc1f
Compare
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
JoanFM
force-pushed
the
feat-make-doclist-a-list
branch
from
April 26, 2023 14:07
162bc1f to
ba6f5f9
Compare
jupyterjazz
reviewed
Apr 26, 2023
samsja
reviewed
Apr 26, 2023
samsja
reviewed
Apr 26, 2023
| @@ -139,7 +142,7 @@ def _del_from_indices(self: T, item: Iterable[int]) -> None: | ||
| # each delete | ||
| del self._data[ix] |
samsja
requested changes
Apr 26, 2023
samsja
left a comment
Member
There was a problem hiding this comment.
but here we still have the _data things this looks weird no ?
Contributor
|
this line is the problem docarray/docarray/index/abstract.py Line 424 in 8df9e7f after this change, it's always true we could do this if not isinstance(docs, DocList) and isinstance(docs, List): |
jupyterjazz
reviewed
Apr 26, 2023
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
JoanFM
force-pushed
the
feat-make-doclist-a-list
branch
from
April 26, 2023 15:41
cefa41b to
65b89d5
Compare
JoanFM
marked this pull request as draft
April 26, 2023 16:42
added 2 commits
April 26, 2023 19:46
…y/docarray into feat-make-doclist-a-list
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
JoanFM
commented
Apr 27, 2023
| return super().__getitem__(item) | ||
|
|
||
| @classmethod | ||
| def __class_getitem__(cls, item: Union[Type[BaseDoc], TypeVar, str]): |
Member
Author
There was a problem hiding this comment.
I'd rather have this redefined at different inheritance levels
Member
There was a problem hiding this comment.
not sure to understand how it will look like
Member
Author
There was a problem hiding this comment.
I do not quite understand this need? what super has another _class_getitem?
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
samsja
marked this pull request as ready for review
April 27, 2023 08:56
samsja
approved these changes
Apr 27, 2023
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
|
📝 Docs are deployed on https://ft-feat-make-doclist-a-list--jina-docs.netlify.app 🎉 |
jupyterjazz
reviewed
Apr 27, 2023
jupyterjazz
left a comment
Contributor
There was a problem hiding this comment.
Nice! I'll try out fastapi integration now
Comment on lines
+191
to
+197
| """Return all v @classmethod | ||
| def __class_getitem__(cls, item: Union[Type[BaseDoc], TypeVar, str]):alues of the fields from all docs this doc_list contains | ||
| @classmethod | ||
| def __class_getitem__(cls, item: Union[Type[BaseDoc], TypeVar, str]): | ||
| :param field: name of the fields to extract | ||
| :return: Returns a list of the field value for each document | ||
| in the doc_list like container |
Contributor
There was a problem hiding this comment.
note for myself to correct this docstring in my fastapi PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR needs to make sure that
DocListis a List, thus fixing the issue that I cannot callschemaof aBaseDochaving nestedDocList.