fix: binary format version bump - #1414
#1414Merged
JoanFM merged 2 commits intoApr 20, 2023
docarray:maindocarray/docarray:mainfrom
nomagick:fix-binary-format-version-bumpnomagick/docarray:fix-binary-format-version-bumpCopy head branch name to clipboard
Merged
fix: binary format version bump#1414JoanFM merged 2 commits intodocarray:maindocarray/docarray:mainfrom nomagick:fix-binary-format-version-bumpnomagick/docarray:fix-binary-format-version-bumpCopy head branch name to clipboard
JoanFM merged 2 commits into
docarray:maindocarray/docarray:mainfrom
nomagick:fix-binary-format-version-bumpnomagick/docarray:fix-binary-format-version-bumpCopy head branch name to clipboard
Conversation
nomagick
marked this pull request as draft
April 18, 2023 09:32
nomagick
force-pushed
the
fix-binary-format-version-bump
branch
2 times, most recently
from
April 18, 2023 13:23
a6badb7 to
90bd85b
Compare
Signed-off-by: Yanlong Wang <yanlong.wang@naiver.org>
nomagick
force-pushed
the
fix-binary-format-version-bump
branch
from
April 18, 2023 13:23
90bd85b to
ef78574
Compare
JoanFM
approved these changes
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The binary format of docarray_v2 has been changed in a non-backward-compatiable way.
In order to tell the difference between docarray_v1 and docarray_v2, a bump in the wire format version is needed.