Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 4590776

Browse filesBrowse files
authored
fix: keep redis default values for vector similarity parameters (#559)
* fix: do not alter redis default configuration * docs: update param docs
1 parent 6ee4500 commit 4590776
Copy full SHA for 4590776

2 files changed

+8-8Lines changed: 8 additions & 8 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎docarray/array/storage/redis/backend.py‎

Copy file name to clipboardExpand all lines: docarray/array/storage/redis/backend.py
+7-7Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import numpy as np
66
from docarray import Document
77
from docarray.array.storage.base.backend import BaseBackendMixin, TypeMap
8-
from docarray.helper import dataclass_from_dict, random_identity
8+
from docarray.helper import dataclass_from_dict, random_identity, filter_dict
99

1010
from redis import Redis
1111
from redis.commands.search.field import NumericField, TextField, VectorField
@@ -28,10 +28,10 @@ class RedisConfig:
2828
tag_indices: List[str] = field(default_factory=list)
2929
batch_size: int = field(default=64)
3030
method: str = field(default='HNSW')
31-
ef_construction: int = field(default=200)
32-
m: int = field(default=16)
33-
ef_runtime: int = field(default=10)
34-
block_size: int = field(default=1048576)
31+
ef_construction: Optional[int] = None
32+
m: Optional[int] = None
33+
ef_runtime: Optional[int] = None
34+
block_size: Optional[int] = None
3535
initial_cap: Optional[int] = None
3636
columns: Optional[Union[List[Tuple[str, str]], Dict[str, str]]] = None
3737

@@ -137,11 +137,11 @@ def _build_schema_from_redis_config(self):
137137
'EF_CONSTRUCTION': self._config.ef_construction,
138138
'EF_RUNTIME': self._config.ef_runtime,
139139
}
140-
index_param.update(index_options)
140+
index_param.update(filter_dict(index_options))
141141

142142
if self._config.method == 'FLAT':
143143
index_options = {'BLOCK_SIZE': self._config.block_size}
144-
index_param.update(index_options)
144+
index_param.update(filter_dict(index_options))
145145

146146
if self._config.initial_cap:
147147
index_param['INITIAL_CAP'] = self._config.initial_cap
Collapse file

‎docs/advanced/document-store/redis.md‎

Copy file name to clipboardExpand all lines: docs/advanced/document-store/redis.md
+1-1Lines changed: 1 addition & 1 deletion
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -492,7 +492,7 @@ The following configs can be set:
492492
| `columns` | Other fields to store in Document and build schema | `None` |
493493

494494
You can check the default values in [the docarray source code](https://github.com/jina-ai/docarray/blob/main/docarray/array/storage/redis/backend.py)
495-
495+
For vector search configurations, default values are those of the database backend, you can find them in [redis documentation](https://redis.io/docs/stack/search/reference/vectors/)
496496

497497
```{note}
498498
We will support geo-filtering soon.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.