Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 2fceb67

Browse filesBrowse files
authored
fix: remove check of default value in _non_empty_fields (#565)
1 parent d9af0c2 commit 2fceb67
Copy full SHA for 2fceb67

2 files changed

+8-6Lines changed: 8 additions & 6 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎docarray/score/data.py‎

Copy file name to clipboardExpand all lines: docarray/score/data.py
+1-6Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,7 @@ def _non_empty_fields(self) -> Tuple[str]:
2323
if not f_name.startswith('_'):
2424
v = getattr(self, f_name)
2525
if v is not None:
26-
if f_name not in default_values:
27-
r.append(f_name)
28-
else:
29-
dv = default_values[f_name]
30-
if v != dv:
31-
r.append(f_name)
26+
r.append(f_name)
3227

3328
return tuple(r)
3429

Collapse file

‎tests/unit/test_named_score.py‎

Copy file name to clipboard
+7Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
from docarray.score import NamedScore
2+
3+
4+
def test_str_representation():
5+
assert str(NamedScore(value=0.0)) == str({'value': 0.0})
6+
assert str(NamedScore(value=None)) == str(dict())
7+
assert str(NamedScore(value=0.3)) == str({'value': 0.3})

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.