Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: 💄 add theme selection to website#697

Open
nutfdt wants to merge 2 commits into
maindnum-mi/basegun:mainfrom
690-add-theme-selectiondnum-mi/basegun:690-add-theme-selectionCopy head branch name to clipboard
Open

feat: 💄 add theme selection to website#697
nutfdt wants to merge 2 commits into
maindnum-mi/basegun:mainfrom
690-add-theme-selectiondnum-mi/basegun:690-add-theme-selectionCopy head branch name to clipboard

Conversation

@nutfdt

@nutfdt nutfdt commented Jan 3, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@nutfdt nutfdt added feature New feature / functionality javascript Pull requests that update Javascript code labels Jan 3, 2025
@nutfdt nutfdt self-assigned this Jan 3, 2025
@nutfdt
nutfdt requested a review from thomashbrnrd as a code owner January 3, 2025 13:19
@nutfdt
nutfdt marked this pull request as draft January 3, 2025 13:19
@github-actions

github-actions Bot commented Jan 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

badge

Backend Coverage Summary

Filename               Stmts    Miss  Cover    Missing
-------------------  -------  ------  -------  -----------------------------
src/__init__.py            0       0  100.00%
src/config.py             45       3  93.33%   79, 81, 83
src/main.py               13       0  100.00%
src/router.py             94      17  81.91%   55, 104-110, 137-140, 161-177
src/utils.py              43       5  88.37%   72-74, 92, 96
tests/__init__.py          0       0  100.00%
tests/conftest.py         14       0  100.00%
tests/test_api.py        113       0  100.00%
tests/test_email.py        4       0  100.00%
TOTAL                    326      25  92.33%

Results for commit: a3f77d4

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions

github-actions Bot commented Jan 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

badge

Frontend Coverage Summary

Filename                                                                      Stmts    Miss  Cover    Missing
--------------------------------------------------------------------------  -------  ------  -------  ------------------------------------------------------------------
src/App.vue                                                                      26       4  84.61%   12, 21-22, 76
src/main.ts                                                                       6       0  100.00%
src/api/api-client.ts                                                            21       4  80.95%   22-23, 27-31
src/api/api-routes.ts                                                             6       0  100.00%
src/components/AppHeader.vue                                                     49       8  83.67%   70-72, 121, 183-184, 233-234
src/components/AskingExpert.vue                                                  27      13  51.85%   24-25, 31-56, 63-69, 83-93
src/components/MissingCardAlert.vue                                               0       0  100.00%
src/components/OnboardingSwiper.vue                                               4       0  100.00%
src/components/PopupVideo.vue                                                    15       4  73.33%   11, 21-25, 93
src/components/ResultPage.vue                                                    41      12  70.73%   50-81, 235-239
src/components/SnackbarAlert.vue                                                 10       9  10.00%   7-20, 28
src/components/StepsGuide.vue                                                     1       0  100.00%
src/router/index.ts                                                              53       2  96.22%   224, 252
src/stores/result.ts                                                             29       0  100.00%
src/stores/snackbar.ts                                                           16       9  43.75%   15-39
src/utils/authentication.ts                                                       2       0  100.00%
src/utils/isUserUsingComputer.ts                                                  1       0  100.00%
src/utils/isUserUsingCrosscall.ts                                                 1       0  100.00%
src/utils/mentions.ts                                                             8       0  100.00%
src/utils/storage-utils.ts                                                        4       0  100.00%
src/utils/firearms-utils/arme-alarme.ts                                           2       1  50.00%   31
src/utils/firearms-utils/autre-pistolet.ts                                        2       1  50.00%   20
src/utils/firearms-utils/epaule-a-levier-sous-garde.ts                            1       0  100.00%
src/utils/firearms-utils/epaule-a-pompe.ts                                        8       2  75.00%   10, 51
src/utils/firearms-utils/epaule-a-un-coup-par-canon.ts                            4       3  25.00%   17-20
src/utils/firearms-utils/epaule-a-verrou.ts                                       1       0  100.00%
src/utils/firearms-utils/epaule-semi-auto-militaire-milieu-20e.ts                 3       2  33.33%   8-22
src/utils/firearms-utils/epaule-semi-auto-style-chasse.ts                         9       7  22.22%   30-38
src/utils/firearms-utils/epaule_mecanisme_ancien.ts                               2       1  50.00%   6
src/utils/firearms-utils/get-next-route-after-result.ts                          15       0  100.00%
src/utils/firearms-utils/index.ts                                                26       6  76.92%   106-107, 113-117
src/utils/firearms-utils/pistolet-mecanisme-ancien.ts                             2       0  100.00%
src/utils/firearms-utils/pistolet-semi-auto-moderne.ts                            4       1  75.00%   72
src/utils/firearms-utils/revolver.ts                                              8       1  87.50%   199
src/utils/firearms-utils/semi-auto-style-militaire-autre.ts                       3       2  33.33%   24-119
src/views/InstructionsPage.vue                                                   62       6  90.32%   48-49, 61-62, 68, 173
src/views/MissingCardPage.vue                                                     9       1  88.88%   36
src/views/StartPage.vue                                                           4       0  100.00%
src/views/GuideAskingExpertise/ExpertContact.vue                                 41       3  92.68%   42, 111, 161
src/views/GuideAskingExpertise/ExpertiseForm.vue                                111      20  81.98%   28, 67-74, 89-104, 118, 134-179, 253, 311, 400, 406, 412, 440, 523
src/views/GuideIdentificationFirearm/GuideIdentificationFirearm.vue              75      24  68.00%   49, 84-112, 120, 210, 236-254, 287-295
src/views/GuideIdentificationFirearm/IdentificationAlarmGun.vue                  12       0  100.00%
src/views/GuideIdentificationFirearm/IdentificationFinalResult.vue                1       0  100.00%
src/views/GuideIdentificationFirearm/IdentificationFurtherInformations.vue        0       0  100.00%
src/views/GuideIdentificationFirearm/IdentificationSelectAmmo.vue                31      12  61.29%   23, 33-38, 43, 57, 88, 103, 123-142
src/views/GuideIdentificationFirearm/IdentificationTypologyResult.vue             1       0  100.00%
src/views/GuideSecuringFirearm/GuideSecuringFirearm.vue                           6       1  83.33%   102
src/views/GuideSecuringFirearm/SecuringAchievement.vue                           14       1  92.85%   102
src/views/GuideSecuringFirearm/SecuringFooter.vue                                 2       0  100.00%
src/views/GuideSecuringFirearm/SecuringSelectOptionContent.vue                   37       7  81.08%   25-26, 41, 140-164
src/views/GuideSecuringFirearm/SecuringTutorialContent.vue                       17       1  94.11%   66
TOTAL                                                                           833     168  79.83%

Results for commit: a3f77d4

Minimum allowed coverage is 75%

♻️ This comment has been updated with latest results

@nutfdt
nutfdt force-pushed the 690-add-theme-selection branch 2 times, most recently from 66c2bf0 to bb1ce24 Compare January 6, 2025 15:25
@nutfdt
nutfdt marked this pull request as ready for review January 6, 2025 15:35
@nutfdt
nutfdt force-pushed the 690-add-theme-selection branch 4 times, most recently from 409458f to 7d4b1c6 Compare January 8, 2025 13:32
@nutfdt
nutfdt force-pushed the 690-add-theme-selection branch from 7d4b1c6 to a3f77d4 Compare January 8, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomashbrnrd thomashbrnrd Awaiting requested review from thomashbrnrd thomashbrnrd is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@nutfdt nutfdt

Labels

feature New feature / functionality javascript Pull requests that update Javascript code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nutfdt
Morty Proxy This is a proxified and sanitized view of the page, visit original site.