Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

✅📝 Add Feature to DiscussionEmbed for Compatibility with SSO - #136

#136
Merged
chrisjtang merged 2 commits into
masterdisqus/disqus-react:masterfrom
sso-embeddisqus/disqus-react:sso-embedCopy head branch name to clipboard
Oct 7, 2022
Merged

✅📝 Add Feature to DiscussionEmbed for Compatibility with SSO#136
chrisjtang merged 2 commits into
masterdisqus/disqus-react:masterfrom
sso-embeddisqus/disqus-react:sso-embedCopy head branch name to clipboard

Conversation

@chrisjtang

@chrisjtang chrisjtang commented Oct 6, 2022

Copy link
Copy Markdown
Contributor

Description

  • Update DiscussionEmbed props and prop checking to display SSO properties if passed in as part of the config.
  • Add tests to DiscussionEmbed for SSO rendering.
  • Update ReadMe with DiscussionEmbed example Component.

Motivation and Context

This PR resolves issues and ambiguity around the compatibility of the DiscussionEmbed component with SSO, which was most recently surfaced in this issue: #135. In previous mentions of SSO compatibility, there were a few changes that were made but no example test sites were ever provided to confirm the validity of the compatibility. Once this PR gets merged and the NPM package gets updated, we will put up a React SSO example that is the equivalent to the current Disqus SSO example here: https://disqus-sso-demo.glitch.me/.

How Has This Been Tested?

  • Added tests to the DiscussionEmbed test suite to test rendering when passing in an SSO config.
  • Tested locally with a mock SSO setup that is using the updated DiscussionEmbed component to display SSO in React (this is the same example mentioned above that will be made available in the near future).

Screenshots (if appropriate):

image

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • All new and existing tests passed.

Chris Tang added 2 commits October 6, 2022 15:02
@chrisjtang
chrisjtang requested a review from Hovspian October 6, 2022 22:24
@chrisjtang chrisjtang self-assigned this Oct 6, 2022

@Hovspian Hovspian left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chrisjtang
chrisjtang merged commit bdc2410 into master Oct 7, 2022
@chrisjtang
chrisjtang deleted the sso-embed branch October 7, 2022 21:13
This was referenced Sep 7, 2024
This was referenced Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.