Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: Enhance URL validation in console logger - #1103

#1103
Open
LaelLuo wants to merge 1 commit into
digitalbazaar:maindigitalbazaar/forge:mainfrom
LaelLuo:mainLaelLuo/forge:mainCopy head branch name to clipboard
Open

feat: Enhance URL validation in console logger#1103
LaelLuo wants to merge 1 commit into
digitalbazaar:maindigitalbazaar/forge:mainfrom
LaelLuo:mainLaelLuo/forge:mainCopy head branch name to clipboard

Conversation

@LaelLuo

@LaelLuo LaelLuo commented Dec 7, 2024

Copy link
Copy Markdown

Changes

  • Add URL API availability check before using URL constructor
  • Include typeof URL !== 'undefined' condition to prevent errors in environments without URL API support

Why

  • Some older browsers or special runtime environments may not support the URL API
  • This check prevents ReferenceError from being thrown in such environments

Impact

  • Improves code robustness and compatibility
  • No functional changes in modern browsers that support URL API

Fixes potential ReferenceError when URL API is not available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.