Replace de.atextor:turtle-formatter with cool.rdf:cool-rdf-formatter#2995
Replace de.atextor:turtle-formatter with cool.rdf:cool-rdf-formatter#2995fkleedorfer wants to merge 15 commits intodiffplug:maindiffplug/spotless:mainfrom fkleedorfer:use-cool-rdf-formatterfkleedorfer/spotless:use-cool-rdf-formatterCopy head branch name to clipboard
Conversation
|
Pending cool-rdf/cool-rdf#66 |
|
Fixes issue #2996 |
|
Ready for review - and I think I need help with these failing tests |
- Add 'rdf' to the special tests list in gradle/special-tests.gradle - Tag RdfFormatterTest class with @tag("rdf") to exclude from standard build matrix - RDF tests can still be run separately with ./gradlew testRdf on Java 25+ This resolves UnsupportedClassVersionError (class file version 69.0) when running tests with Java 17, 21, and 24 in the CI pipeline.
|
@nedtwigg I think this is ready for review now |
# Conflicts: # plugin-maven/CHANGES.md
The PR excluded RDF tests from CI by adding 'rdf' to the special-tests exclusion list. Remove it and drop @tag("rdf") so these tests run with the rest of the suite.
|
I made a few commits, take a look at each. Now that the test are running, they are failing because the new formatter requires Java 25+. One of two things needs to happen:
|
Head branch was pushed to by a user without write access
|
Tried with JRE 25 in the test matrix, but those tests fail in many places. That makes me wonder whether spotless supports JRE 25 in general. Without 25 in the matrix, the build succeeds but the rdf tests are excluced as per the test's annotation. |
|
@nedtwigg fixed it, and tested the snapshot maven plugin on the sources I normally use it for, looks like it's working as expected, including the friendly error message telling me to update my java version. |
Please DO NOT FORCE PUSH. Don't worry about messy history, it's easier to do code review if we can tell what happened after the review, and force pushing breaks that.
Please make sure that your PR allows edits from maintainers. Sometimes it's faster for us to just fix something than it is to describe how to fix it.
After creating the PR, please add a commit that adds a bullet-point under the
[Unreleased]section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:If your change only affects a build plugin, and not the lib, then you only need to update the
plugin-foo/CHANGES.mdfor that plugin.If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update
CHANGES.mdfor both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.This makes it easier for the maintainers to quickly release your changes :)