Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Closes #693 - Fix issue with vuestorefront having wrong folder name #765

Merged
Thomas-Boi merged 2 commits into
developdevicons/devicon:developfrom
thomas/fixvuestorefrontdevicons/devicon:thomas/fixvuestorefrontCopy head branch name to clipboard
Jul 21, 2021
Merged

Closes #693 - Fix issue with vuestorefront having wrong folder name #765
Thomas-Boi merged 2 commits into
developdevicons/devicon:developfrom
thomas/fixvuestorefrontdevicons/devicon:thomas/fixvuestorefrontCopy head branch name to clipboard

Conversation

@Thomas-Boi

Copy link
Copy Markdown
Member

This should fixes #693.

Git doesn't track capital-sensitivity in file paths, thus a simple file name changes locally doesn't fix it. This PR basically removes the folder in one commit and restore it in a different name in another, hopefully causes git to track it.

@amacado amacado left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git doesn't track capital-sensitivity in file paths

yep, I had this problem in other projects as well.. You came up with a solution, I will use it in some other cases 👍🏻

@Panquesito7 Panquesito7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing this out and for the fix. 🙂

@Panquesito7 Panquesito7 added bug Use this label for pointing out bugs and removed enhancement labels Jul 21, 2021
@Thomas-Boi

Copy link
Copy Markdown
Member Author

I'll merge this in. The icons are still the same so this won't show up in the build release

@Thomas-Boi
Thomas-Boi merged commit 5c1d3d5 into develop Jul 21, 2021
@Panquesito7
Panquesito7 deleted the thomas/fixvuestorefront branch July 21, 2021 21:30
@Panquesito7 Panquesito7 linked an issue Aug 6, 2021 that may be closed by this pull request
@amacado amacado mentioned this pull request Aug 14, 2021
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
…r name (devicons#765)

* Remove vueStorefront

* Readd vuestorefront in proper folder name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Use this label for pointing out bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug Report: svg file of "vuestorefront" not exist.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.