new icon: subversion (original, original-wordmark) by MichielPater · Pull Request #731 · devicons/devicon

MichielPater · Jul 7, 2021

And re-sorted icons starting with 's' alphabetically

- re-sorted icons starting with 's' alphabetically

github-actions · Jul 7, 2021

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

icons/subversion/subversion-original-wordmark.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

icons/subversion/subversion-original.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out.

Added wordmark to subversion Co-authored-by: David Leal <halfpacho@gmail.com>

Added aliases to subversion Co-authored-by: David Leal <halfpacho@gmail.com>

Added viewbox to subversion Co-authored-by: David Leal <halfpacho@gmail.com>

Added viewport to subversion Co-authored-by: David Leal <halfpacho@gmail.com>

github-actions · Jul 9, 2021

Hi there,

I'm Devicons' Peek Bot and it seems we've ran into a problem.

Expecting ',' delimiter: line 3566 column 13 (char 75110)

Make sure that:

Your svgs are named and added correctly to the /icons folder as seen here.
Your icon information has been added to the devicon.json as seen here
Your PR title follows the format seen here

I will retry once everything is fixed. If I still fail or there are other error, the maintainers will investigate.

Best of luck,
Peek Bot ☺️

Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>

github-actions · Jul 9, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Here are the zoomed-in screenshots of the added icons:

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

github-actions · Jul 9, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Here are the zoomed-in screenshots of the added icons:

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>

This has been resolved

github-actions · Jul 13, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Here are the zoomed-in screenshots of the added icons:

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Thomas-Boi

I was wrong about the wordmark version being icon friendly. I'll remove it from the devicon.json for you.

github-actions · Jul 13, 2021

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Here are the zoomed-in screenshots of the added icons:

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

Thomas-Boi

The icon is great now. Thank you for your work @MichielPater. Looking forward to your other PRs.

* new icon: subversion (original, original-wordmark) - re-sorted icons starting with 's' alphabetically * Update devicon.json Added wordmark to subversion Co-authored-by: David Leal <halfpacho@gmail.com> * Update devicon.json Added aliases to subversion Co-authored-by: David Leal <halfpacho@gmail.com> * Update icons/subversion/subversion-original-wordmark.svg Added viewbox to subversion Co-authored-by: David Leal <halfpacho@gmail.com> * Update icons/subversion/subversion-original.svg Added viewport to subversion Co-authored-by: David Leal <halfpacho@gmail.com> * Update devicon.json (fix) Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * Update devicon.json Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: David Leal <halfpacho@gmail.com> Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>

new icon: subversion (original, original-wordmark)

a38a9a4

- re-sorted icons starting with 's' alphabetically

Panquesito7 added the feature:icon PR when a new icon is ready to be added to the collection label Jul 7, 2021

Panquesito7 previously requested changes Jul 7, 2021

View reviewed changes

Comment thread devicon.json

Comment thread devicon.json Outdated

Comment thread icons/subversion/subversion-original-wordmark.svg Outdated

Comment thread icons/subversion/subversion-original.svg Outdated

MichielPater and others added 4 commits July 7, 2021 21:41

Update devicon.json

4328c0b

Added wordmark to subversion Co-authored-by: David Leal <halfpacho@gmail.com>

Update devicon.json

e747976

Added aliases to subversion Co-authored-by: David Leal <halfpacho@gmail.com>

Update icons/subversion/subversion-original-wordmark.svg

b56b78d

Added viewbox to subversion Co-authored-by: David Leal <halfpacho@gmail.com>

Update icons/subversion/subversion-original.svg

1b72564

Added viewport to subversion Co-authored-by: David Leal <halfpacho@gmail.com>

Thomas-Boi added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Jul 9, 2021

Thomas-Boi reviewed Jul 9, 2021

View reviewed changes

Comment thread devicon.json

Update devicon.json (fix)

711b749

Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>

Thomas-Boi added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 9, 2021

Thomas-Boi reviewed Jul 9, 2021

View reviewed changes

Comment thread devicon.json Outdated

MichielPater and others added 2 commits July 13, 2021 14:23

Update devicon.json

a3b9a31

Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>

Merge branch 'develop' into add-subversion

88e5b32

Thomas-Boi added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 13, 2021

Thomas-Boi reviewed Jul 13, 2021

View reviewed changes

Comment thread devicon.json Outdated

Comment thread devicon.json Outdated

Apply suggestions from code review

f181b76

Thomas-Boi added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 13, 2021

Thomas-Boi approved these changes Jul 13, 2021

View reviewed changes

Thomas-Boi merged commit 4fa0b0f into devicons:develop Jul 13, 2021

Thomas-Boi mentioned this pull request Aug 14, 2021

Build preparation for release v2.13.0 #811

Merged

amacado mentioned this pull request Aug 14, 2021

Release v2.13.0 #812

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

new icon: subversion (original, original-wordmark)#731

new icon: subversion (original, original-wordmark)#731
Thomas-Boi merged 9 commits into
devicons:developdevicons/devicon:developfrom
MichielPater:add-subversionCopy head branch name to clipboard

MichielPater commented Jul 7, 2021

Uh oh!

github-actions Bot commented Jul 7, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2021

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2021

Uh oh!

github-actions Bot commented Jul 9, 2021

Uh oh!

Uh oh!

github-actions Bot commented Jul 13, 2021

Uh oh!

Thomas-Boi left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 13, 2021

Uh oh!

Thomas-Boi left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Search code, repositories, users, issues, pull requests...

Uh oh!

Conversation

MichielPater commented Jul 7, 2021

Uh oh!

github-actions Bot commented Jul 7, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2021

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2021

Uh oh!

github-actions Bot commented Jul 9, 2021

Uh oh!

Uh oh!

github-actions Bot commented Jul 13, 2021

Uh oh!

Thomas-Boi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 13, 2021

Uh oh!

Thomas-Boi left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Thomas-Boi left a comment •

edited

Loading