Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

new icon: opengl (original)#727

Merged
Thomas-Boi merged 14 commits into
devicons:developdevicons/devicon:developfrom
MichielPater:add-openglCopy head branch name to clipboard
Jul 24, 2021
Merged

new icon: opengl (original)#727
Thomas-Boi merged 14 commits into
devicons:developdevicons/devicon:developfrom
MichielPater:add-openglCopy head branch name to clipboard

Conversation

@MichielPater

Copy link
Copy Markdown
Contributor

And re-sorted icons starting with 'o' alphabetically

- re-sorted icons starting with 'o' alphabetically
@Panquesito7 Panquesito7 added the feature:icon PR when a new icon is ready to be added to the collection label Jul 7, 2021
@github-actions

github-actions Bot commented Jul 7, 2021

Copy link
Copy Markdown
Contributor

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

icons/opengl/opengl-original.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out.

Comment thread devicon.json Outdated
Comment thread icons/opengl/opengl-original.svg Outdated
MichielPater and others added 2 commits July 7, 2021 21:29
Added opengl aliases

Co-authored-by: David Leal <halfpacho@gmail.com>
Added opengl viewport

Co-authored-by: David Leal <halfpacho@gmail.com>
@Thomas-Boi Thomas-Boi added the bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger label Jul 9, 2021
@github-actions

This comment has been minimized.

Comment thread devicon.json
Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
@Thomas-Boi Thomas-Boi added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 9, 2021
@github-actions

github-actions Bot commented Jul 9, 2021

Copy link
Copy Markdown
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@Thomas-Boi

Copy link
Copy Markdown
Member

The icon looks good 👍. The edges are a bit blurry but that's due to the shadow in the original.

Would you be interested in making a plain version that's the same as the original but without the shadows? We'll keep the original but the no-shadow one will be the plain version. If you're too busy, I can merge this branch as is into the repo as well.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Hi!

I'm Devicons' SVG-Checker Bot and it seems we have some issues with your SVGs.

Here is what went wrong:

icons/opengl/opengl-plain.svg:
-'viewBox' is not '0 0 128 128' -> Set it or scale the file using https://www.iloveimg.com/resize-image/resize-svg

For more reference on why these are errors, check out our CONTRIBUTING guide

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

PS. One day, I will be smart enough to fix these errors for you 😣. Until then, I can only point them out.

Comment thread icons/opengl/opengl-original.svg Outdated
Comment thread icons/opengl/opengl-plain.svg Outdated
@Thomas-Boi Thomas-Boi added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger and removed bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger labels Jul 22, 2021
@github-actions

Copy link
Copy Markdown
Contributor

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.
Here is the result below (top left):

Imgur Images

Here are the zoomed-in screenshots of the added icons:
Imgur Images

Note: If the images don't show up, it's probably because it has been autodeleted by Imgur after 6 months due to our API choice.

The maintainers will now take a look at it and decide whether to merge your PR.

Thank you for contributing to Devicon! I hope everything works out and your icons are accepted into the repo.

Cheers,
Peek Bot 😊

@Panquesito7 Panquesito7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution! 👍 🎉

@Thomas-Boi

Copy link
Copy Markdown
Member

Sorry for the late review. Everything looks great now!

@Thomas-Boi
Thomas-Boi merged commit f820731 into devicons:develop Jul 24, 2021
@amacado amacado mentioned this pull request Aug 14, 2021
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
* new icon: opengl (original)
- re-sorted icons starting with 'o' alphabetically

* Update devicon.json

Added opengl aliases

Co-authored-by: David Leal <halfpacho@gmail.com>

* Update icons/opengl/opengl-original.svg

Added opengl viewport

Co-authored-by: David Leal <halfpacho@gmail.com>

* Update devicon.json (fix)

Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>

* OpenGL plain icon added

* opengl-plain: Viewbox added

* Update icons/opengl/opengl-plain.svg

Co-authored-by: David Leal <halfpacho@gmail.com>

* Update icons/opengl/opengl-original.svg

Co-authored-by: David Leal <halfpacho@gmail.com>

* Apply suggestions from code review

Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: Thomas Bui <43018778+Thomas-Boi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.