Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Devtools] Update Readme Links#46

Merged
Jdubrick merged 2 commits into
devfile-samples:v2.0.0devfile-samples/devfile-sample-python-basic:v2.0.0from
Jdubrick:v2.0.0Jdubrick/devfile-sample-python-basic:v2.0.0Copy head branch name to clipboard
Mar 1, 2024
Merged

[Devtools] Update Readme Links#46
Jdubrick merged 2 commits into
devfile-samples:v2.0.0devfile-samples/devfile-sample-python-basic:v2.0.0from
Jdubrick:v2.0.0Jdubrick/devfile-sample-python-basic:v2.0.0Copy head branch name to clipboard

Conversation

@Jdubrick

Copy link
Copy Markdown
Contributor

This PR updates the readme file to contain the proper code reference links for the various files. Since v2.0.0 also utilizes a parent devfile, references were altered and included to properly outline this connection.

Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>

@michael-valdron michael-valdron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! A few revisions I would suggest.

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>

@michael-valdron michael-valdron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Jdubrick Jdubrick merged commit cb5784c into devfile-samples:v2.0.0 Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.