add tests for projects and starter projects#360
add tests for projects and starter projects#360mmulholla merged 4 commits intodevfile:masterdevfile/api:masterfrom mmulholla:AddTestsForProjectsCopy head branch name to clipboard
Conversation
johnmcollier
left a comment
There was a problem hiding this comment.
I see you're making a lot of calls to generate random strings and numbers. My concern is that it could make the api test results non-reproducible between runs.
Wondering also if we need to test the GitHub project type now that it's been deprecated? (#349)
|
@johnmcollier I added an extra commit because the starter projects I was creating failed validation because they are restricted to one remote. |
maysunfaisal
left a comment
There was a problem hiding this comment.
looks good, follows the existing test convention.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: johnmcollier, maysunfaisal, mmulholla The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
Add test for projects and starter project to the new api test.
The code added will be shared with the library tests.