docs: close stale finding 0002 (HSTS/CSP) — fix already shipped in #98 - #107
#107Merged
devSealWare merged 2 commits intoJul 10, 2026
maindevSealWare/LightIPAM:mainfrom
docs/close-finding-0002devSealWare/LightIPAM:docs/close-finding-0002Copy head branch name to clipboard
Merged
docs: close stale finding 0002 (HSTS/CSP) — fix already shipped in #98#107devSealWare merged 2 commits intomaindevSealWare/LightIPAM:mainfrom docs/close-finding-0002devSealWare/LightIPAM:docs/close-finding-0002Copy head branch name to clipboard
devSealWare merged 2 commits into
maindevSealWare/LightIPAM:mainfrom
docs/close-finding-0002devSealWare/LightIPAM:docs/close-finding-0002Copy head branch name to clipboard
Conversation
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finding 0002 (missing HSTS header, incomplete CSP) was already fixed in commit 332547a (#98, "fix(security): emit HSTS conditionally and harden CSP"), but its finding doc was never cleaned up per the doc-sync convention.
Verified PR #98's diff covers everything the finding doc asked for:
securityHeadersnow emitsStrict-Transport-Security: max-age=31536000; includeSubDomains, gated on the existingCookieSecureconfig flag (option 2 from the finding's fix instructions — avoids a spoofableX-Forwarded-Protocheck).base-uri 'self'; object-src 'none'added to the policy string.internal/app/security_test.goadded, covering CSP directives and both HSTS on/off states.docs/SECURITY.md: "Product Security Features" already documents the header baseline including conditional HSTS.[Unreleased] / Fixedreferencingdocs/agent/findings/0002.Only the finding-doc/tracker cleanup was missed — this PR does just that.
Scope
docs/agent/findings/0002-missing-hsts-csp-hardening.md(removed)docs/agent/findings/README.md(open-findings table now empty)Non-goals
main.Validation
Docs-only.
go build ./... && go vet ./...go test ./...gofmt -l internal cmdis cleanSecurity / scanner boundary checklist