Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

docs: close stale finding 0002 (HSTS/CSP) — fix already shipped in #98 - #107

#107
Merged
devSealWare merged 2 commits into
maindevSealWare/LightIPAM:mainfrom
docs/close-finding-0002devSealWare/LightIPAM:docs/close-finding-0002Copy head branch name to clipboard
Jul 10, 2026
Merged

docs: close stale finding 0002 (HSTS/CSP) — fix already shipped in #98#107
devSealWare merged 2 commits into
maindevSealWare/LightIPAM:mainfrom
docs/close-finding-0002devSealWare/LightIPAM:docs/close-finding-0002Copy head branch name to clipboard

Conversation

@devSealWare

Copy link
Copy Markdown
Owner

Summary

Finding 0002 (missing HSTS header, incomplete CSP) was already fixed in commit 332547a (#98, "fix(security): emit HSTS conditionally and harden CSP"), but its finding doc was never cleaned up per the doc-sync convention.

Verified PR #98's diff covers everything the finding doc asked for:

  • HSTS: securityHeaders now emits Strict-Transport-Security: max-age=31536000; includeSubDomains, gated on the existing CookieSecure config flag (option 2 from the finding's fix instructions — avoids a spoofable X-Forwarded-Proto check).
  • CSP hardening: base-uri 'self'; object-src 'none' added to the policy string.
  • Test coverage: internal/app/security_test.go added, covering CSP directives and both HSTS on/off states.
  • docs/SECURITY.md: "Product Security Features" already documents the header baseline including conditional HSTS.
  • CHANGELOG: already has a one-line entry under [Unreleased] / Fixed referencing docs/agent/findings/0002.

Only the finding-doc/tracker cleanup was missed — this PR does just that.

Scope

  • docs/agent/findings/0002-missing-hsts-csp-hardening.md (removed)
  • docs/agent/findings/README.md (open-findings table now empty)

Non-goals

  • No code or CHANGELOG change — both were already correct on main.

Validation

Docs-only.

  • go build ./... && go vet ./...
  • go test ./...
  • gofmt -l internal cmd is clean

Security / scanner boundary checklist

  • The web app remains unprivileged.
  • No raw sockets, nmap, packet capture, or network capability were added to the app.
  • Scanner-agent privilege boundaries are unchanged or explicitly justified.
  • App-side and agent-side scan allowlist checks remain intact where relevant.
  • Strict CSP preserved — no inline JS/CSS; generated CSS came from the Tailwind source.
  • No unrelated refactors or dependency additions.

@devSealWare
devSealWare merged commit cfd83bf into main Jul 10, 2026
7 checks passed
@devSealWare
devSealWare deleted the docs/close-finding-0002 branch July 10, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.