chore(vmclass): discovered features should be frozen after first discovery#2664
Merged
diafour merged 2 commits intoJul 14, 2026
maindeckhouse/virtualization:mainfrom
chore/vmclass/fix-mutable-status-features-enabled-for-discovery-classdeckhouse/virtualization:chore/vmclass/fix-mutable-status-features-enabled-for-discovery-classCopy head branch name to clipboard
Merged
chore(vmclass): discovered features should be frozen after first discovery#2664diafour merged 2 commits intomaindeckhouse/virtualization:mainfrom chore/vmclass/fix-mutable-status-features-enabled-for-discovery-classdeckhouse/virtualization:chore/vmclass/fix-mutable-status-features-enabled-for-discovery-classCopy head branch name to clipboard
diafour merged 2 commits into
maindeckhouse/virtualization:mainfrom
chore/vmclass/fix-mutable-status-features-enabled-for-discovery-classdeckhouse/virtualization:chore/vmclass/fix-mutable-status-features-enabled-for-discovery-classCopy head branch name to clipboard
Conversation
…overy - Use first time discovered feature set to filter availableNodes on later reconciles. - Add errors in case no availableNodes are present in the cluster. Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
yaroslavborbat
previously approved these changes
Jul 14, 2026
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
yaroslavborbat
approved these changes
Jul 14, 2026
diafour
deleted the
chore/vmclass/fix-mutable-status-features-enabled-for-discovery-class
branch
July 14, 2026 12:18
deckhouse-BOaTswain
pushed a commit
that referenced
this pull request
Jul 16, 2026
…overy (#2664) * chore(vmclass): discovered features should be frozen after first discovery - Use first time discovered feature set to filter availableNodes on later reconciles. - Add errors in case no availableNodes are present in the cluster. --------- Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
deckhouse-BOaTswain
pushed a commit
that referenced
this pull request
Jul 22, 2026
…overy (#2664) * chore(vmclass): discovered features should be frozen after first discovery - Use first time discovered feature set to filter availableNodes on later reconciles. - Add errors in case no availableNodes are present in the cluster. --------- Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Why do we need it, and what problem does it solve?
It fixes regression in #2501: vmclass.Status.Features.Enabled becomes mutable.
What is the expected result?
CPU features in
vmclass.Status.Features.Enabledis immutable after first discovery. New nodes that matches spec.nodeSelector should also match discovered features.Checklist
Changelog entries