Assert rom_backup_data_address stays within RAM at link time#129
Open
dogruis wants to merge 1 commit into
dciabrin:masterdciabrin/ngdevkit:masterfrom
dogruis:assert-rom-backup-data-addressdogruis/ngdevkit:assert-rom-backup-data-addressCopy head branch name to clipboard
Open
Assert rom_backup_data_address stays within RAM at link time#129dogruis wants to merge 1 commit intodciabrin:masterdciabrin/ngdevkit:masterfrom dogruis:assert-rom-backup-data-addressdogruis/ngdevkit:assert-rom-backup-data-addressCopy head branch name to clipboard
dogruis wants to merge 1 commit into
dciabrin:masterdciabrin/ngdevkit:masterfrom
dogruis:assert-rom-backup-data-addressdogruis/ngdevkit:assert-rom-backup-data-addressCopy head branch name to clipboard
Conversation
Setting rom_backup_data_address to an invalid value (below ORIGIN(RAM) or past ORIGIN(RAM) + LENGTH(RAM)) currently produces a working ELF whose runtime accesses to .bss.bram silently corrupt memory. Two ASSERTs catch the misconfiguration at link time without changing behavior for valid placements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
rom_backup_data_addressto an invalid value (belowORIGIN(RAM)or pastORIGIN(RAM) + LENGTH(RAM)) currently produces a working ELF whose runtime accesses to.bss.bramsilently corrupt memory. TwoASSERTstatements inruntime/ngdevkit.ldcatch the misconfiguration at link time without changing behavior for any valid placement.