Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 505f07a

Browse filesBrowse files
authored
fix: minor fixes related to release (coder#5732)
* fix: use * for test plugin engines This removes the need to update this version with every version change. * refactor: use npm-package in release assets This adds a new job to `release.yaml` to upload the `npm-package` to the release assets which will also allow us to download it in the `publish.yaml` workflow. * docs: update release instructions * fixup!: use package.tar.gz
1 parent ee47293 commit 505f07a
Copy full SHA for 505f07a

4 files changed

+29-11Lines changed: 29 additions & 11 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎.github/workflows/publish.yaml‎

Copy file name to clipboardExpand all lines: .github/workflows/publish.yaml
+6-8Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,13 @@ jobs:
2828
id: version
2929
run: echo "::set-output name=version::$(jq -r .version package.json)"
3030

31-
- name: Download artifact
32-
uses: dawidd6/action-download-artifact@v2
33-
id: download
31+
- name: Download npm package from release artifacts
32+
uses: robinraju/release-downloader@v1.5
3433
with:
35-
branch: release/v${{ steps.version.outputs.version }}
36-
workflow: build.yaml
37-
workflow_conclusion: completed
38-
name: "npm-package"
39-
path: release-npm-package
34+
repository: "coder/code-server"
35+
tag: v${{ steps.version.outputs.version }}
36+
fileName: "package.tar.gz"
37+
out-file-path: "release-npm-package"
4038

4139
- name: Publish npm package and tag with "latest"
4240
run: yarn publish:npm
Collapse file

‎.github/workflows/release.yaml‎

Copy file name to clipboardExpand all lines: .github/workflows/release.yaml
+21Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -249,3 +249,24 @@ jobs:
249249
draft: true
250250
discussion_category_name: "📣 Announcements"
251251
files: ./release-packages/*
252+
253+
npm-package:
254+
name: Upload npm package
255+
runs-on: ubuntu-latest
256+
timeout-minutes: 15
257+
steps:
258+
- name: Download artifacts
259+
uses: dawidd6/action-download-artifact@v2
260+
id: download
261+
with:
262+
branch: ${{ github.ref }}
263+
workflow: build.yaml
264+
workflow_conclusion: completed
265+
check_artifacts: true
266+
name: npm-package
267+
268+
- uses: softprops/action-gh-release@v1
269+
with:
270+
draft: true
271+
discussion_category_name: "📣 Announcements"
272+
files: ./package.tar.gz
Collapse file

‎docs/MAINTAINING.md‎

Copy file name to clipboardExpand all lines: docs/MAINTAINING.md
+1-2Lines changed: 1 addition & 2 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,7 @@ changelog](https://github.com/emacs-mirror/emacs/blob/master/etc/NEWS).
141141

142142
### Publishing a release
143143

144-
1. Create a new branch called `release/v0.0.0` (replace 0s with actual version aka v4.5.0)
145-
1. If you don't do this, the `npm-brew` GitHub workflow will fail. It looks for the release artifacts under the branch pattern.
144+
1. Create a new branch called `release`
146145
1. Run `yarn release:prep`
147146
1. Bump chart version in `Chart.yaml`.
148147
1. Summarize the major changes in the `CHANGELOG.md`
Collapse file

‎test/unit/node/test-plugin/package.json‎

Copy file name to clipboardExpand all lines: test/unit/node/test-plugin/package.json
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"name": "test-plugin",
44
"version": "1.0.0",
55
"engines": {
6-
"code-server": "^4.8.1"
6+
"code-server": "*"
77
},
88
"main": "out/index.js",
99
"devDependencies": {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.