feat: added filter by connection names to operations#6
Merged
feat: added filter by connection names to operations#6
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds optional connection-name filtering (conn_names) to DSSession operations so callers can target a subset of active connections (and includes tests covering key filtered operations).
Changes:
- Added
conn_names: list[str] | Noneparameter to multipleDSSessionAPIs (tables, assignments, aggregation, workspace ops, close, etc.). - Implemented
_get_selected_connections()helper to centralize connection filtering. - Added a new test module validating filtering behavior across several operations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
datashield/api.py |
Extends session APIs with conn_names filtering and adds _get_selected_connections(); adjusts close() and sessions() logic. |
tests/test_session_filters.py |
Adds unit tests for filtered operations (tables, assign_expr, aggregate, workspace methods, close). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.