Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix: patch aiohttp init in tests - #118

#118
Open
maudetes wants to merge 3 commits into
maindatagouv/api-tabular:mainfrom
fix/patch-aiohttp-initdatagouv/api-tabular:fix/patch-aiohttp-initCopy head branch name to clipboard
Open

fix: patch aiohttp init in tests#118
maudetes wants to merge 3 commits into
maindatagouv/api-tabular:mainfrom
fix/patch-aiohttp-initdatagouv/api-tabular:fix/patch-aiohttp-initCopy head branch name to clipboard

Conversation

@maudetes

@maudetes maudetes commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Fix CI

aioresponses is not yet compatible with aiohttp 3.14+ (upgraded in 9533522).

This is a workaround to make tests pass.

See pnuckowski/aioresponses#289

maudetes added 2 commits June 22, 2026 12:03
aioresponses is not yet compatible with aiohttp 3.14+ (upgraded in 9533522).
This is a workaround to make tests pass.
See pnuckowski/aioresponses#289
@maudetes maudetes changed the title fix: patch aiohttp init fix: patch aiohttp init in tests Jun 22, 2026

@bolinocroustibat bolinocroustibat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry I missed that!
We could also revert to <0.4.0 waiting for the fix to be released.
I would advise not to, but we could add a comment to remind it's a temporary complication while waiting for the aioresponses fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.