Security: Potential Sensitive Information Exposure in Logging#804
Open
tomaioo wants to merge 1 commit into
databricks:maindatabricks/databricks-sql-python:mainfrom
tomaioo:fix/security/potential-sensitive-information-exposuretomaioo/databricks-sql-python:fix/security/potential-sensitive-information-exposureCopy head branch name to clipboard
Open
Security: Potential Sensitive Information Exposure in Logging#804tomaioo wants to merge 1 commit intodatabricks:maindatabricks/databricks-sql-python:mainfrom tomaioo:fix/security/potential-sensitive-information-exposuretomaioo/databricks-sql-python:fix/security/potential-sensitive-information-exposureCopy head branch name to clipboard
tomaioo wants to merge 1 commit into
databricks:maindatabricks/databricks-sql-python:mainfrom
tomaioo:fix/security/potential-sensitive-information-exposuretomaioo/databricks-sql-python:fix/security/potential-sensitive-information-exposureCopy head branch name to clipboard
Conversation
The `src/databricks/sql/experimental/oauth_persistence.py` file logs token persistence operations at INFO level, including the file path where OAuth tokens are stored. While not the tokens themselves, the file path could be sensitive. More critically, the `DevOnlyFilePersistence` class stores OAuth tokens (access_token and refresh_token) in plaintext JSON without encryption, which is noted as development-only but still presents a risk if misused in production. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Potential Sensitive Information Exposure in Logging
Problem
Severity:
Medium| File:src/databricks/sql/experimental/oauth_persistence.py:L56The
src/databricks/sql/experimental/oauth_persistence.pyfile logs token persistence operations at INFO level, including the file path where OAuth tokens are stored. While not the tokens themselves, the file path could be sensitive. More critically, theDevOnlyFilePersistenceclass stores OAuth tokens (access_token and refresh_token) in plaintext JSON without encryption, which is noted as development-only but still presents a risk if misused in production.Solution
Add warnings when DevOnlyFilePersistence is instantiated in non-development environments. Consider encrypting the file or using OS keyring services. Reduce log level for persistence operations or ensure no sensitive data is logged.
Changes
src/databricks/sql/experimental/oauth_persistence.py(modified)