Fix inline list parameter rendering for IN clauses#773
Open
fatkobra wants to merge 2 commits into
databricks:maindatabricks/databricks-sql-python:mainfrom
fatkobra:Fix-inline-list-param-rendering-for-IN-clausesfatkobra/databricks-sql-python:Fix-inline-list-param-rendering-for-IN-clausesCopy head branch name to clipboard
Open
Fix inline list parameter rendering for IN clauses#773fatkobra wants to merge 2 commits intodatabricks:maindatabricks/databricks-sql-python:mainfrom fatkobra:Fix-inline-list-param-rendering-for-IN-clausesfatkobra/databricks-sql-python:Fix-inline-list-param-rendering-for-IN-clausesCopy head branch name to clipboard
fatkobra wants to merge 2 commits into
databricks:maindatabricks/databricks-sql-python:mainfrom
fatkobra:Fix-inline-list-param-rendering-for-IN-clausesfatkobra/databricks-sql-python:Fix-inline-list-param-rendering-for-IN-clausesCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Fixes #629
Closes #629
Summary
INclauses(…)instead ofARRAY(…)How is this tested?
poetry run python -m pytest tests/unit/test_param_escaper.py
poetry run python -m pytest tests/unit/test_parameters.py tests/unit/test_param_escaper.py
poetry run python -m pytest tests/unit
poetry run python -m black src tests --check
Unit tests
E2E Tests
Manually
N/A
Related Tickets & Documents
Closes #629