[PECO-AI] PECOBLR-1968: Add warnings in logs if someone uses a connection param that is not defined in python sql connector#752
Open
nikhilsuri-db wants to merge 1 commit into
maindatabricks/databricks-sql-python:mainfrom
peco-ai-PECOBLR-1968-3databricks/databricks-sql-python:peco-ai-PECOBLR-1968-3Copy head branch name to clipboard
Open
[PECO-AI] PECOBLR-1968: Add warnings in logs if someone uses a connection param that is not defined in python sql connector#752nikhilsuri-db wants to merge 1 commit intomaindatabricks/databricks-sql-python:mainfrom peco-ai-PECOBLR-1968-3databricks/databricks-sql-python:peco-ai-PECOBLR-1968-3Copy head branch name to clipboard
nikhilsuri-db wants to merge 1 commit into
maindatabricks/databricks-sql-python:mainfrom
peco-ai-PECOBLR-1968-3databricks/databricks-sql-python:peco-ai-PECOBLR-1968-3Copy head branch name to clipboard
Conversation
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description: PECO Agent Workflow (Partner Ecosystem)
Jira Ticket: https://databricks.atlassian.net/browse/PECOBLR-1968
Changes
Added a
KNOWN_KWARGSfrozenset constant toclient.pylisting all recognized**kwargskeys consumed byConnection.__init__and its downstream callees. Immediately after thelogger.debug(...)call, the code computes the set difference between provided keys andKNOWN_KWARGS, then emits alogger.warningif any unknown keys are found. Three tests were added toClientTestSuiteto verify the warning behavior.Test Cases Written
test_unknown_connection_param_issues_warning— verifies that passing an unrecognized kwarg callslogger.warningtest_unknown_connection_param_warning_names_the_param— verifies the warning message contains the unkno...Summary: Added a
KNOWN_KWARGSfrozenset constant toclient.pylisting all recognized**kwargskeys consumed byConnection.__init__and its downstream callees. Immediately after thelogger.debug(...)call, the code computes the set difference between provided keys andKNOWN_KWARGS, then emits alogger.warningif any unknown keys are found. Three tests were added toClientTestSuiteto verify the warning behavior.